9.16 - 8.6% tabswitch / tabswitch + 1 more (Linux) regression on Tue September 6 2022
Categories
(Firefox :: Theme, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr91 | --- | unaffected |
firefox-esr102 | --- | unaffected |
firefox104 | --- | unaffected |
firefox105 | --- | unaffected |
firefox106 | --- | fixed |
People
(Reporter: aglavic, Assigned: emilio)
References
(Regression)
Details
(4 keywords)
Attachments
(1 file, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details |
Perfherder has detected a talos performance regression from push de5bd66dff7834e7eab425b7091f38140cc26ea9. As author of one of the patches included in that push, we need your help to address this regression.
Regressions:
Ratio | Test | Platform | Options | Absolute values (old vs new) |
---|---|---|---|---|
9% | tabswitch | linux1804-64-shippable-qr | e10s fission stylo webrender-sw | 6.93 -> 7.56 |
9% | tabswitch | linux1804-64-shippable-qr | e10s fission stylo webrender | 6.95 -> 7.57 |
9% | tabswitch | linux1804-64-shippable-qr | e10s fission stylo webrender | 6.98 -> 7.58 |
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.
If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.
For more information on performance sheriffing please see our FAQ.
Comment 1•2 years ago
|
||
Set release status flags based on info from the regressing bug 1789125
Assignee | ||
Comment 2•2 years ago
|
||
I'm a bit baffled about bug 1789877. My best theory so far is that we're
inserting the element a bit deeper in the DOM and that causes us to
reflow slightly more stuff when tab-switching, but...
In any case while going through the code the status panel can be
simplified a bit now, so do that.
Updated•2 years ago
|
Comment 3•2 years ago
|
||
Comment on attachment 9293772 [details]
Bug 1789877 - Simplify statuspanel a bit. r=dao
Revision D156876 was moved to bug 1789892. Setting attachment 9293772 [details] to obsolete.
Assignee | ||
Comment 4•2 years ago
|
||
shows improvements from just making the invisible status panel display: none
, so yeah, it's probably reflow slowness when moving the status panel around.
Assignee | ||
Comment 5•2 years ago
|
||
Mostly for reference, since this does fix the regression and avoids
having frames for the panel in ~all cases.
I guess it'd be nice to keep the fade-in transitions (tho tbh I had
never noticed them).
Dao, do you know if we have an existing pattern for such thing? I know
panels do that with transitionend listeners and so, I can do that but if
we have existing code to do that it'd be great.
Assignee | ||
Updated•2 years ago
|
Updated•2 years ago
|
Comment 7•2 years ago
|
||
bugherder |
Comment 8•2 years ago
|
||
== Change summary for alert #35407 (as of Fri, 16 Sep 2022 12:08:44 GMT) ==
Improvements:
Ratio | Test | Platform | Options | Absolute values (old vs new) |
---|---|---|---|---|
8% | tabswitch | linux1804-64-shippable-qr | e10s fission stylo webrender | 7.53 -> 6.89 |
8% | tabswitch | linux1804-64-shippable-qr | e10s fission stylo webrender-sw | 7.48 -> 6.90 |
7% | tabswitch | linux1804-64-shippable-qr | e10s fission stylo webrender | 7.53 -> 6.97 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=35407
Assignee | ||
Updated•2 years ago
|
Description
•