Found in

• Nightly 106.0a1

Affected versions

• Nightly 106.0a1
• Firefox 105.0b9

Tested platforms

• Affected platforms: Windows 10, Windows 7
• Unaffected platforms: macOS, Ubuntu

Precondotion

• Make sure that the "Never" option is set for Combine taskbar buttons (Personalize -> Taskbar Settings).

Steps to reproduce

1. Download a locale build (FR for example).
2. Open Firefox and pin Private Browser icon to taskbar.
3. Observe the name.

Expected result

• The name is translated to French.

Actual result

• The name is still in English.

Regression range

• This is not a regression

Notes

• If the icon is pinned to Start menu, the name is translated to French.

This issue is still reproducing on IT and AR builds while using Firefox 106.0b4.

Which part is not translated? Everything in the screenshot looks localized to me.

If you hover the icon from the taskbar, the name is not localized.

Also when a Private Window is opened, then the name next to the PBM icon is not translated.

(In reply to Oana Botisan, Desktop Release QA from comment #3)

If you hover the icon from the taskbar, the name is not localized.

Also when a Private Window is opened, then the name next to the PBM icon is not translated.

The fact that the string next to the icon in the browser itself is not translated makes this sound like we're just waiting for localization to happen. However, it looks to me like the string has been translated for months for the it locale. It also can't reproduce this with the 106.0b4 it build (screenshot attached).

A couple of more things that may be useful:

• A complete screencast showing the problem, starting with where you get the installer from
• A copy of any Firefox shortcuts in %appdata%\microsoft\windows\start menu\programs or %programdata%\microsoft\windows\start menu\programs after the problem occurs.

Also adding flod, on the off change I'm misunderstanding something about the state of the translation.

Italian is normally translated within a few hours from landing, so if something shows up in English, there is something wrong in the code.

The IT locale is translated for me, too. What happened was that I used dedicated profiles and because I opened the Italian build with an existing profile, the titles weren't translated.
In the %appdata%\microsoft\windows\start menu\programs folder I can find both the shortcut for "Firefox Private Browsing" and "Firefox - Navigatione anonima" shortcuts. In the %programdata%\microsoft\windows\start menu\programs folder only one instance of "Firefox" shortcut can be found.

Just as an additional note, the shortcut is stil in %appdata%\microsoft\windows\start menu\programs even after the icon was unpinned. Is that expected?

Ar builds ar not translated as can it be seen from the attachment. And for this build in the folders %appdata%\microsoft\windows\start menu\programs%appdata%\microsoft\windows\start menu\programs there is no shortcut created.

(In reply to Oana Botisan, Desktop Release QA from comment #7)

Created attachment 9296595 [details]
title not translated with wxisting profile.gif

The IT locale is translated for me, too. What happened was that I used dedicated profiles and because I opened the Italian build with an existing profile, the titles weren't translated.

In the %appdata%\microsoft\windows\start menu\programs folder I can find both the shortcut for "Firefox Private Browsing" and "Firefox - Navigatione anonima" shortcuts. In the %programdata%\microsoft\windows\start menu\programs folder only one instance of "Firefox" shortcut can be found.

OK, so we have two shortcuts, but the en-US one is getting chosen. This is not too surprising, although not great. I'm doing some work around this in https://bugzilla.mozilla.org/show_bug.cgi?id=1792547 and can probably fix this case as well.

Just as an additional note, the shortcut is stil in %appdata%\microsoft\windows\start menu\programs even after the icon was unpinned. Is that expected?

Yes, that's normal. Nothing to worry about here!

(In reply to Oana Botisan, Desktop Release QA from comment #8)

Created attachment 9296599 [details]
AR builds.gif

Ar builds ar not translated as can it be seen from the attachment. And for this build in the folders %appdata%\microsoft\windows\start menu\programs%appdata%\microsoft\windows\start menu\programs there is no shortcut created.

This locale either hasn't completed their translated yet, or has decided that the English string is acceptable. There's no technical issues with it as far as I can tell.

Thank you for all the detailed information! I think we have enough to call this a valid bug, and move forward.

(In reply to bhearsum@mozilla.com (:bhearsum) from comment #9)

This locale either hasn't completed their translated yet, or has decided that the English string is acceptable. There's no technical issues with it as far as I can tell.

The former. Please rely on Italian for testing Nightly, or Beta for French, those are reliably localized.
https://transvision.flod.org/string/?entity=browser/installer/custom.properties:PRIVATE_BROWSING_SHORTCUT_TITLE&repo=gecko_strings

Can you give it a try with this build? It's got the patches from https://bugzilla.mozilla.org/show_bug.cgi?id=1794017 applied to it, and I suspect it may fix this issue as well, as it improves detection of existing shortcuts.

We verified the issue with the try build on Windows 10 and Windows 11 using FR, IT and DE language. The title is translated while the Private Window is opened, but if it's closed then the title is in EN-US.

We changed the languages in about:preferences after we changed these prefs:

• intl.multilingual.downloadEnabled = true
• intl.multilingual.enabled = true
• intl.multilingual.liveReload = true
• extensions.getAddons.langpacks.url = https://mock-amo-language-tools.glitch.me/?app=firefox&type=language&appversion=%VERSION%

(In reply to Oana Botisan, Desktop Release QA from comment #12)

We verified the issue with the try build on Windows 10 and Windows 11 using FR, IT and DE language. The title is translated while the Private Window is opened, but if it's closed then the title is in EN-US.

We changed the languages in about:preferences after we changed these prefs:

• intl.multilingual.downloadEnabled = true
• intl.multilingual.enabled = true
• intl.multilingual.liveReload = true
• extensions.getAddons.langpacks.url = https://mock-amo-language-tools.glitch.me/?app=firefox&type=language&appversion=%VERSION%

Thank you for testing. A couple more questions:

• Can you list all of the Firefox installs you have on the test system, and which locale they are?
• Can you attach all of the Firefox shortcuts you can find?

My suspicion is that you've overwritten an en-US Firefox install with a localized one, or visa versa - which would mean you have a shortcut for one locale that doesn't match the currently installed locale. (I'm not sure we can do anything about this, but it would be nice to verify...)

The try build you gave us was an en-US build. So the only way we could verify the fix was if we changed the language from about:preferences (any language you select from the list), which means that it only changes the language of the browser, but in essence the build is still en-US. So it doesn't overwrite anything.
What I found interesting was that, as it can be seen in the attachment, the title is translated while the Private Window is opened, but it's not when the window is closed.

However I verified the fix using latest Nightly 107.0a1 (DE, FR and IT builds) and the issue is not reproducing anymore. The title is translated even if the Private Window is closed. The only thing that might still be here an issue is that there is an inconsistance in the way that the title is displayed: sometimes the translation is between brakes, other times you have a "-" between Firefox Nightly and the translation for Private Browsing.

This looks to me like a shortcut with en-US strings, while the app itself is localized. This could happen for at least a couple of reasons that we can't really fix:

1. If en-US Firefox was ever installed to this location in the past, and created a private shortcut (this is why I wanted to know about overwrites and any shortcuts that exist already)
2. If the locale hasn't completed translation yet (unlikely at this point, but possible)

It sounds like you can't reproduce anymore, so I will close this. If you encounter more problems, I request a couple things to make any follow-ups more actionable:

1. That you can reproduce in a VM or system that has never had Firefox installed before. There are many reasons why having previous installs could cause issues like this -- but nearly all of them would not be reproducible by a user in the wild.
2. That you attach all Firefox lnk files from %programdata%\microsoft\windows\start menu\programs, %appdata%\microsoft\windows\start menu\programs, and other place you can find them.