Make XUL splitters use the height property rather than attribute.
Categories
(Core :: Layout, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox107 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Regressed 1 open bug)
Details
Attachments
(5 files)
This will allow XUL splitters to work with flex boxes rather than XUL boxes.
|
Assignee | |
Comment 1•2 years ago
|
||
Existing splitter and DevTools tests keep passing with this.
|
|
Assignee | |
Comment 2•2 years ago
|
||
No behavior change intended.
Depends on D157062
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3c1db9604720 Make XUL splitter use height property rather than attribute. r=jdescottes,tnikkel
|
|
Assignee | |
Comment 4•2 years ago
|
||
This allows DevTools to be resized with emulated flexbox.
|
|
Assignee | |
Updated•2 years ago
|
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
|
||
Comment 6•2 years ago
|
||
After this bug landed i can not resize the devTools when it on left or right side.
only when devTools is on bottom resize work
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3175a8c01387 Minor clean-ups to XUL splitter code. r=tnikkel
|
||
Comment 8•2 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 9•2 years ago
|
||
Now that this doesn't involve an attribute lookup it's not worth it, and
this allows querying the flex of emulated flex items without hitting
assertions due to the lack of box metrics.
|
||
Comment 10•2 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/54ebb0e34ad3 Make GetXULFlex not cache the resolved flex value anymore. r=dholbert
|
|
||
Comment 11•2 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bf86de479585 Make nsSplitterFrame work with regular flex boxes. r=dholbert,layout-reviewers
|
||
Comment 12•2 years ago
|
||
Backed out changeset bf86de479585 (Bug 1790299) for causing failures in test_splitter.xhtml CLOSED TREE
Log: https://treeherder.mozilla.org/logviewer?job_id=391009673&repo=autoland&lineNumber=4888
Backout: https://hg.mozilla.org/integration/autoland/rev/ef44d7041454440fdd144b79c115c8d6439ec31a
|
||
Comment 13•2 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•2 years ago
|
|
|
||
Comment 14•2 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/15d13eb291b4 Make nsSplitterFrame work with regular flex boxes. r=dholbert,layout-reviewers
|
|
||
Comment 15•2 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 16•2 years ago
|
||
This doesn't have any behavior change, test-only. I wrote this while
debugging the previous patches. Modern flexbox respects width/height
over flex, which is not true for legacy flexbox, so this makes the
box sizes match, effectively, which makes it easier to compare to figure
out regressions.
|
|
||
Comment 17•2 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c949d841e3e9 Make test more similar between xul/non-xul. r=dholbert
|
|
Assignee | |
Updated•2 years ago
|
|
||
Comment 18•2 years ago
|
||
| bugherder | ||
Description
•