Found in

• Firefox Nightly 106.0a1

Affected versions

• Nightly 106.0a1

Tested platforms

• Affected platforms: Windows 10x64, macOS 10.12.6 and Ubuntu 18.4

Steps to reproduce

1. Launch Firefox
2. Right Click on the Firefox View tab and choose Pin to the Overflow menu option
3. Go to the Overflow menu right click on the Firefox View and select unpin from Overflow menu
4. Open the Firefox View tab
5. Minimize the browser using the toolbar button
6. Click on Firefox browser to bring it back in view
7. Observe the Firefox View feature call out onboarding container

Expected result

• Onboarding container is displayed properly in the Firefox View tab pickup.

Actual result

• Feature call out onboarding container is not showing properly after pinning and unpinning Firefox View tab while minimizing the browser.

Note: It may be necessary to repeat the reproducing steps a couple of times to catch the onboarding defect
Note: See the attached screenshot
Regression range New Feature

This issue only affects the continuous onboarding reminders (tab pickup, colorways)
From here...
I've found some other folks reporting similar ReactDOM errors on google. Maybe updating ReactDOM will fix it.

Stack trace:

TypeError: c is not a function
    React 19
        Ch
        unstable_runWithPriority
        Da
        Ch
        Dh
        Aj
        unstable_runWithPriority
        Da
        ab
        Te
        Pg
        unstable_runWithPriority
        Da
        Pg
        ha
        Ja
        md
        nd
        render
    mount resource://activity-stream/aboutwelcome/aboutwelcome.bundle.js:1932
    async* resource://activity-stream/aboutwelcome/aboutwelcome.bundle.js:1939
    <anonymous> resource://activity-stream/aboutwelcome/aboutwelcome.bundle.js:1940
    <anonymous> resource://activity-stream/aboutwelcome/aboutwelcome.bundle.js:1942
react-dom.js:125:24

It looks like when you initially open the tab, you're getting a continuous onboarding reminder. Then when you minimize the tab, the visibilitychange event fires, which performs another targeting check. Since we've now seen the reminder, its lifetime is expired and this new check returns a new message (in my case, the feature tour). At that point, it tries to show the feature tour while the continuous onboarding reminder is still up, and presumably that is borking something.

Also avoid loading redundant resources and listeners when a feature
callout is added on visibilitychange.

I think bug 1791094 is related - this is also what I'm seeing, where it seems like the priority of continuous onboarding messages gets reversed and they start showing before the feature tour. Alternatively, it could be that something is just preventing the feature tour from being shown at all.

https://hg.mozilla.org/mozilla-central/rev/69f0db94dd20

The patch landed in nightly and beta is affected.
:aminomancer, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox106 to wontfix.

For more information, please visit auto_nag documentation.

I have verified this issue using the Latest Firefox Nightly 107.0a1 (Build ID: 20221003212025) on Windows 10x64, macOS 12.5 and Linux Mint 20.3 and I can confirm the following:

• The callout messages are correctly displayed after pinning/unpinning the Firefox View tab while minimizing the browser.