DevToolsSocketStatus does not track browser toolbox connections
Categories
(DevTools :: General, defect, P3)
Tracking
(firefox106 fixed)
Tracking | Status | |
---|---|---|
firefox106 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
DevToolsSocketStatus is supposed to keep track of all the open socket for devtools. This is currently only used by https://searchfox.org/mozilla-central/source/browser/base/content/browser.js#8382 to decide to display or not the browser automation cue (stripes in the URL bar + robot icon).
However we explicitly avoid tracking Browser Toolbox sockets here, because we didn't want the Browser Toolbox to trigger the automation styling in the original Firefox instance.
This works fine for the browser.js use case, but it makes the DevToolsSocketStatus misleading, if someone else wants to start using it to really track all devtools sockets.
So DevToolsSocketStatus should probably track all opened sockets, but acknowledge the difference between BrowserToolbox and non-BrowserToolbox sockets.
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
The DevToolsSocketStatus could be misleading for any usage other than the current one from browser.js since it misses browser toolbox sockets
This patch allows the singleton to track all sockets but changes the API to allow consumers to exclude browser toolbox sockets.
Updated•2 years ago
|
Comment 3•2 years ago
|
||
bugherder |
Description
•