Open Bug 1790853 Opened 2 years ago Updated 2 years ago

Firefox View might want to offer users a way to dismiss sensitive/unwanted Tab Pickup tiles

Categories

(Firefox :: Firefox View, enhancement, P3)

enhancement

Tracking

()

REOPENED

People

(Reporter: dholbert, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fidefe-2022-mr1-firefox-view])

scenario:

  1. User visits a "sensitive" site on one device (a NSFW site, or "Engagement Rings 'R Us", or a site with secret/sensitive info in the title)
  2. User steps away from that device.
  3. Later on, user opens a different device and checks Firefox View.
  4. User sees prominently featured "Tab Pickup: [The Sensitive Site That They Visited On The Other Device]"
  5. User is alarmed and wants to hide that tile. But there's no clear way to do so.

If they don't have easy/immediate access to the other device, then this tile will potentially persist there indefinitely, I think (?)

Do we want to offer users any way to dismiss these "Last Active" tiles?

(For comparison, on the new-tab page, we offer a 3-dot menu at the top right to let the user "Dismiss" or even "DeleteFromHistory" the visited sites there. So I intuitively expect that Firefox View might have similar options available.)

(ni=Gijs for thoughts; do we have plans/thoughts around addressing this scenario?)

Flags: needinfo?(gijskruitbosch+bugs)

The same issue is here for "Recently Closed Tabs", to a lesser extent. Similar scenario: visit some sensitive site, close the tab, visit Firefox View and realize your sensitive site is shown there. There at least, there are several workarounds (not super obvious, but they're there) -- it looks like you could do any of the following: (1) close the window, (2) restart the browser, (3) choose "forget about this site" for the site in question in our history UI.

In contrast, none of those will clear the Tab Pickup tiles (I just tested). (I wasn't sure if a local "Forget About This Site" would remove the site from Tab Pickup tiles, but I tested and it doesn't. And that's probably correct behavior, technically? Since it is of course still true that the site is my last active tab on a separate device, even if all associated history has been cleared on this device.)

In any case, I think we need to offer some mitigation for dismissing a Tab Pickup suggestion locally, ideally discoverable from the tile itself.

I can also imagine a Tab Pickup "dismiss" operation having some gray areas that we would need to hammer down, and which might make it tricky to implement robustly.

Some open questions to think about, if/when we address this:

  • Would we just dismiss the URL as a "one-off action" right now, or would we add the site to a persistent block-list?
  • (if we do it as a one-off, will it just show up in 10 minutes when my next sync operation happens? That's not great.)
  • (if we do it as some sort of persistent block-list, does that list get synced? Does it get purged when the user clears history or does "forget-about-this-site" etc? Is there a way I can undo the Dismiss action to let a site show up again, if I dismiss a site by accident and want to undo that?)

We might want to follow or draw inspiration from whatever approach we use for new-tab-page "dismiss" actions, though I can imagine things being more complex here.

(In reply to Daniel Holbert [:dholbert] from comment #1)

(ni=Gijs for thoughts; do we have plans/thoughts around addressing this scenario?)

Not right now, beyond the obvious "you can collapse the list". 301 in terms of future things for Ray.

Note that all this information (and more!) is/was already available (and also not delete-able) from the accounts menu and synced tabs sidebar, so although I sympathise with the concern I'm pretty confident this doesn't need to block shipping and isn't urgent.

(In reply to Daniel Holbert [:dholbert] from comment #2)

The same issue is here for "Recently Closed Tabs", to a lesser extent.

This is bug 1787945. Beyond collapsing the list the other simple workaround is opening a new window and closing the previous one (potentially moving any tabs you do want to keep).

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(rfambro)
Whiteboard: [fidefe-2022-mr1-firefox-view]

(In reply to Daniel Holbert [:dholbert] from comment #3)

I can also imagine a Tab Pickup "dismiss" operation having some gray areas that we would need to hammer down, and which might make it tricky to implement robustly.

Some open questions to think about, if/when we address this:

  • Would we just dismiss the URL as a "one-off action" right now, or would we add the site to a persistent block-list?
  • (if we do it as a one-off, will it just show up in 10 minutes when my next sync operation happens? That's not great.)
  • (if we do it as some sort of persistent block-list, does that list get synced? Does it get purged when the user clears history or does "forget-about-this-site" etc? Is there a way I can undo the Dismiss action to let a site show up again, if I dismiss a site by accident and want to undo that?)

We might want to follow or draw inspiration from whatever approach we use for new-tab-page "dismiss" actions, though I can imagine things being more complex here.

I mean, more bizarrely, to persist the list we need to save the list to disk. If you're syncing a work and home computer, maintaining a list of NSFW sites on your work computer is also going to be 🤔. I guess we could hash them with a per-profile seed but that doesn't help all that much.

Flags: needinfo?(rfambro)
Severity: -- → S3
Priority: -- → P3

Great feedback and much appreciated Daniel! We will definitely revisit alternatives to this potential user concern in the future. Let's first confirm that it is indeed an issue once it ships out first. As Gijs mentioned, there are some workarounds currently in the UX that can mitigate this scenario. We won't block shipping now though and will keep this top of mind for the next iteration.

FWIW, I just noticed that Fenix's ~equivalent UI does indeed offer a "dismiss" option. So we apparently have something like the UX that I'm requesting here already-implemented there.

On Fenix, in the "Jump back in" section on the homepage, there is[1] a tile that shows one synced tab, plus a "See all synced tabs" button. If I long-press that tile, it gives me a context menu with a single option, "Remove", which dismisses that synced tab and shows me a different synced tab instead.

[1] Sometimes it takes a few seconds for that tile to appear; maybe it waits for a sync to complete.

Great flag! Will take a closer look at this behavior as we plan forward on a FxView solution here.

Flags: needinfo?(jberman)

We opened a jira ticket for this. Will be tackling the work (FXCD-220 & FXCD-221)

Flags: needinfo?(jberman)
Blocks: 1788692
No longer blocks: firefox-view
Blocks: firefox-view
Duplicate of this bug: 1793807
No longer duplicate of this bug: 1793807
Status: NEW → RESOLVED
Closed: 2 years ago
Duplicate of bug: 1793807
Resolution: --- → DUPLICATE
Status: RESOLVED → REOPENED
No longer duplicate of bug: 1793807
Resolution: DUPLICATE → ---

Wanted to circle back on an update here. Acknowledging the timing of the release trains + the anticipation of an updated UI for the Tab Pickup section + upcoming User Research, we will hold off on picking up the "dismiss/hide" functionality here. The team will reconvene in January and discuss a path forward at that time.

You need to log in before you can comment on or make changes to this bug.