Closed Bug 1790971 Opened 2 years ago Closed 2 years ago

Closing all tabs with browser.tabs.closeWindowWithLastTab set to false shows Firefox View tab instead of new tab page

Categories

(Firefox :: Tabbed Browser, defect, P3)

Product:
Firefox
Component:
Tabbed Browser
Version:
Firefox 106
Type:
defect
Points:
2

Tracking

()

Status:
VERIFIED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- unaffected
firefox104 --- unaffected
firefox105 --- unaffected
firefox106 --- wontfix
firefox107 --- wontfix
firefox108 --- verified
firefox109 --- verified

People

(Reporter: ke5trel, Assigned: bigiri)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-firefox-view])

Attachments

(2 files)

Video of closing last tab showing Firefox View instead of new tab
(deleted), video/webm
Details
Bug 1790971 - Prevent Firefox View Tab from being autoselected on tab closing r=Dao!
(deleted), text/x-phabricator-request
Details

STR:

  1. Set browser.tabs.closeWindowWithLastTab = false.
  2. Click the Firefox View tab so it is loaded.
  3. Visit sites in new tabs and then close all tabs.

Expected:

Shows new tab page like before.

Actual:

Opens a new tab but switches to the Firefox View tab.

Does not happen if the Firefox View tab is unloaded. With browser.tabs.closeWindowWithLastTab = true, the Firefox View tab is ignored and the window is closed as expected.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=38bea6dcef3951a8b6788d33ebf592bfd58aebd6&tochange=d2f85d26d71bfe0ef1f7ae279829a18c845c3454

Regressed by Bug 1771311.

:dao, since you are the author of the regressor, bug 1771311, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Flags: needinfo?(dao+bmo)
Component: Firefox View → Tabbed Browser
Flags: needinfo?(dao+bmo)
Keywords: regression
No longer regressed by: 1771311
Severity: -- → S3
Priority: -- → P3
Whiteboard: [fidefe-firefox-view]
Blocks: 1797520
No longer blocks: firefox-view
Assignee: nobody → bigiri
Status: NEW → ASSIGNED

Prevent pinned Firefox View Tab from being autoselected on tab closing.

Pushed by bigiri@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/42ac056d9440 Prevent Firefox View Tab from being autoselected on tab closing r=dao
Points: --- → 2

https://hg.mozilla.org/mozilla-central/rev/42ac056d9440

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit auto_nag documentation.

status-firefox107: --- → affected

The patch landed in nightly and beta is affected.
:bigiri, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox107 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(bigiri)

Possible regression in bug 1799393

status-firefox107: affected → wontfix
Flags: needinfo?(bigiri)
Flags: qe-verify+

Reproducible on a 2022-09-15 Nightly build on macOS 12 using the STR from Comment 0.
Verified as fixed on Firefox 108.0b2(build ID: 20221115200658) and Nightly 109.0a1(build ID: 20221116182402) on macOS 12, Windows 10, Ubuntu 22.

Status: RESOLVED → VERIFIED
status-firefox108: fixed → verified
status-firefox109: --- → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: