Open Bug 1791175 Opened 2 years ago Updated 1 year ago

New wpt failures in /css/css-images/gradient/ [gradient-eval-002.html, gradient-eval-003.html, gradient-eval-005.html, and 4 others] due to lack of support for "in lab" gradient syntax

Categories

(Core :: Layout: Images, Video, and HTML Frames, defect)

Product:
Core
Component:
Layout: Images, Video, and HTML Frames
Type:
defect

Tracking

()

Status:
REOPENED

People

(Reporter: mozilla.org, Assigned: tlouw)

References

Details

(Whiteboard: [wpt])

Attachments

(1 file)

testcase with a variety of linear-gradient expressions
(deleted), text/html
Details

Syncing wpt PR 35931 found new untriaged test failures in CI

Tests Affected

Firefox-only failures

New Tests That Don't Pass

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1791166 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

These tests all seem to be testing css-color-4 stuff -- specifically lab and lch in color syntax:
https://www.w3.org/TR/css-color-4/#color-syntax

So, this is dependent on bug 1128204 and bug 1352757, essentially; but let's just mark it as depending on the css-color-4 metabug.

Severity: -- → S4
Depends on: css-color-4

These tests are now passing, because of bug 1128204 and bug 1352757.

Changes are still behind a feature flag. Would it be ok to close this as fixed before enabling it?

Yup, that's fine. Thanks!

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Depends on: 1128204, 1352757

Hmm, we've enabled the feature flag for lab colors, but these tests referenced in comment 0 here (2-3,5-9) still fail. It seems we don't support the linear-gradient(in lab, ...) syntax. I'll attach a testcase to demonstrate, but e.g. a trivial data-URI testcase is:
data:text/html,<body style="background: linear-gradient(in lab, blue, orange);">

Firefox rejects that linear-gradient expression as invalid CSS. Tiaan, could you take a look when you get a chance?

Status: RESOLVED → REOPENED
Flags: needinfo?(tlouw)
Resolution: FIXED → ---
Summary: New wpt failures in /css/css-images/gradient/ [gradient-eval-002.html, gradient-eval-003.html, gradient-eval-005.html, and 4 others] → New wpt failures in /css/css-images/gradient/ [gradient-eval-002.html, gradient-eval-003.html, gradient-eval-005.html, and 4 others] due to lack of support for "in lab" gradient syntax

Here's a testcase to demonstrate. We render the gradient in the final box here, which shows that we do support lab colors in linear-gradient; but we apparently don't support the in lab syntax that all of the other boxes use (and which these WPT tests rely upon).

I'll pick this one up

Assignee: nobody → tlouw
Flags: needinfo?(tlouw)

This will get us a fairly nice bump in our interop-2023 score, FWIW -- potentially a 3.3% improvement in our "Color Spaces and Functions" focus-area score.

Our color score is currently 199.6 / 211 = 94.6%, and this bug here is associated with 7 test-failures -- so with this fixed, we'll probably be at 206.6/211 = 97.9%

(After this, the remaining test failures are mostly one-off subtests within other multi-part tests.)

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: