Closed Bug 1791176 Opened 2 years ago Closed 2 years ago

[Colorway CLoset] The hover effect for the Address Bar items is not visible with certain Colorway themes with Bold intensity

Categories

(Firefox :: Theme, defect, P3)

Product:
Firefox
Component:
Theme
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
108 Branch
Project Flags:
Accessibility Severity s3
Tracking Flags:
Tracking Status
firefox106 --- wontfix
firefox107 --- wontfix
firefox108 --- verified

People

(Reporter: atrif, Assigned: kpatenio)

References

Details

(Keywords: access, Whiteboard: [fidefe-2022-colorway-closet])

Attachments

(2 files)

colorway_01.gif
(deleted), image/gif
Details
Bug 1791176 - update address bar hover effect for certain bold colorways. r=dao!,bigiri!
(deleted), text/x-phabricator-request
Details
Attached image colorway_01.gif (deleted) —

Found in

  • 106.0a1 (20220916033628)

Affected versions

  • 106.0a1 (20220916033628)

Tested platforms

  • Affected platforms:
  • Windows 10x64
  • macOS 11
  • Ubuntu 21.04

Preconditions

  • set browser.theme.colorway-closet:true and browser.tabs.firefox-view:true

Steps to reproduce

  1. Set Colorway theme to Activist > Bold
  2. Open a random webpage and hover over the URL bar elements.

Expected result

  • The hover effect can be seen.

Actual result

  • The hover effect is not visible.

Regression range

  • I don't think this is a regression. I can reproduce the issue starting with bug 1771775.

Additional notes

  • Attached a screen recording.
  • A similar issue can be seen when using Dreamer > Bold colorway theme where the hover effect is not so visible as on other Colorway themes.
Has STR: --- → yes
Whiteboard: [fidefe-2022-colorway-closet]
Keywords: access
Priority: -- → P3
Assignee: nobody → kpatenio
Status: NEW → ASSIGNED
Whiteboard: [fidefe-2022-colorway-closet] → [fidefe-2022-colorway-closet][access-s3]

The severity field for this bug is set to S4. However, the accessibility severity is higher, [access-s3].
:kpatenio, could you consider increasing the severity?

For more information, please visit auto_nag documentation.

Flags: needinfo?(kpatenio)
Severity: S4 → S3

Ray already increased the severity of this ticket. Thanks!

Flags: needinfo?(kpatenio)
Attachment #9298534 - Attachment description: WIP: Bug 1791176 - update address bar hover effect for certain bold colorways. r=dao!,bigiri! → Bug 1791176 - update address bar hover effect for certain bold colorways. r=dao!,bigiri!
Pushed by kpatenio@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e0461448f69d update address bar hover effect for certain bold colorways. r=bigiri

https://hg.mozilla.org/mozilla-central/rev/e0461448f69d

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit auto_nag documentation.

status-firefox107: --- → affected

The patch landed in nightly and beta is affected.
:kpatenio, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox107 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(kpatenio)
Depends on: 1796569
Depends on: 1796571
Flags: needinfo?(kpatenio)

Verified fixed with Firefox 108.0a1 (2022-10-27) on Windows 10x64, macOS 12 and Ubuntu 20.04. The hover effect is now visible after following the steps from comment 0.

Status: RESOLVED → VERIFIED
status-firefox108: fixed → verified
Accessibility Severity: --- → s3
Whiteboard: [fidefe-2022-colorway-closet][access-s3] → [fidefe-2022-colorway-closet]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: