[wpt-sync] Sync PR 35966 - Update script result_ownership tests to handle id is only on root
Categories
(Remote Protocol :: WebDriver BiDi, task, P4)
Tracking
(firefox113 fixed)
Tracking | Status | |
---|---|---|
firefox113 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 35966 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/35966
Details from upstream follow.
Julian Descottes <jdescottes@mozilla.com> wrote:
Update script result_ownership tests to handle id is only on root
Per serialization spec, child ownership is always set to "none" before serializing values. This means that only the root can ever have a handle id set.
Our current tests for resultOwnership="root" assert that a handle is set on the root remote value, but not that nested remote values do not have a handle id.
Assignee | ||
Updated•2 years ago
|
Updated•2 years ago
|
Comment 1•2 years ago
|
||
We should discuss the proposal from Julian on the upstream PR.
Comment 2•2 years ago
|
||
Will ask for review again and move the discussion to another issue
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
Assignee | ||
Comment 4•2 years ago
|
||
CI Results
Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 41 tests and 1 subtests
Status Summary
Firefox
OK
: 41
PASS
: 623[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview] 624[Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 628[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub]
FAIL
: 7[Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub] 8[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview]
Chrome
OK
: 41
PASS
: 516
FAIL
: 119
Safari
OK
: 41
ERROR
: 635
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /webdriver/tests/bidi/script/add_preload_script/add_preload_script_tentative.py [wpt.fyi]
- test_add_preload_script[tab]:
FAIL
[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview
],PASS
[Gecko-android-em-7.0-x86_64-qr-debug-geckoview
,Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview
,Gecko-android-em-7.0-x86_64-qr-opt-geckoview
,Gecko-linux1804-64-qr-debug
,Gecko-linux1804-64-qr-opt
,Gecko-windows11-32-2009-qr-debug
,Gecko-windows11-32-2009-qr-opt
,Gecko-windows11-64-2009-qr-debug
,Gecko-windows11-64-2009-qr-opt
,GitHub
] (Chrome:FAIL
, Safari:ERROR
)
- test_add_preload_script[tab]:
- /webdriver/tests/bidi/script/call_function/exception_details.py [wpt.fyi]
- test_exception_details[new WeakSet()-expected25-False]:
FAIL
(Chrome:PASS
, Safari:ERROR
) - test_exception_details[new Error('SOME_ERROR_TEXT')-expected26-False]:
FAIL
(Chrome:PASS
, Safari:ERROR
) - test_exception_details[Promise.resolve()-expected27-False]:
FAIL
(Chrome:PASS
, Safari:ERROR
) - test_exception_details[new Int32Array()-expected28-False]:
FAIL
(Chrome:PASS
, Safari:ERROR
) - test_exception_details[new ArrayBuffer()-expected29-False]:
FAIL
(Chrome:PASS
, Safari:ERROR
) - test_exception_details[document.createElement('div')-expected30-False]:
FAIL
(Chrome:PASS
, Safari:ERROR
) - test_exception_details[window-expected31-False]:
FAIL
(Chrome:PASS
, Safari:ERROR
)
- test_exception_details[new WeakSet()-expected25-False]:
Updated•2 years ago
|
Updated•2 years ago
|
Comment 6•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b5d0763e696b
https://hg.mozilla.org/mozilla-central/rev/6b55852cf7e8
Description
•