Closed Bug 1792203 Opened 2 years ago Closed 2 years ago

AsyncBlockers might not immediately resolve promise when called with no blocker registered

Categories

(Core :: IPC, defect, P2)

Product:
Core
Component:
IPC
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

Attachments

(2 files)

Bug 1792203 - Add gtest coverage for AsyncBlockers r?nika!
(deleted), text/x-phabricator-request
Details
Bug 1792203 - Immediately resolve AsyncBlockers when no blocker are registered r?nika!
(deleted), text/x-phabricator-request
Details
No description provided.

The severity field is not set for this bug.
:jld, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jld)
Severity: -- → S3
Priority: -- → P2
Flags: needinfo?(jld)
Attachment #9295982 - Attachment description: WIP: Bug 1792203 - Add gtest coverage for AsyncBlockers → Bug 1792203 - Add gtest coverage for AsyncBlockers r?nika!
Attachment #9295986 - Attachment description: WIP: Bug 1792203 - Immediately resolve AsyncBlockers when no blocker are registered → Bug 1792203 - Immediately resolve AsyncBlockers when no blocker are registered r?nika!
Pushed by alissy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/862f59a3f38c Add gtest coverage for AsyncBlockers r=nika https://hg.mozilla.org/integration/autoland/rev/b597f145ec59 Immediately resolve AsyncBlockers when no blocker are registered r=nika
Flags: needinfo?(lissyx+mozillians)
Pushed by alissy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/119c65339140 Add gtest coverage for AsyncBlockers r=nika https://hg.mozilla.org/integration/autoland/rev/d9048386628e Immediately resolve AsyncBlockers when no blocker are registered r=nika

Backed out for causing gtest failures.

Push with failures

Failure log
we also got the time out followed by this crash: https://treeherder.mozilla.org/logviewer?job_id=394287507&repo=autoland&lineNumber=11515

Backout link

[task 2022-10-25T18:34:01.522Z] 18:34:01     INFO -  TEST-START | TestAsyncBlockers.DeregisterEmpty
[task 2022-10-25T18:34:01.763Z] 18:34:01     INFO -  Running GTest tests...
[task 2022-10-25T18:39:02.214Z] 18:39:02     INFO -  gtest INFO | gtest | process wait complete, returncode=5
[task 2022-10-25T18:39:02.215Z] 18:39:02  WARNING -  gtest TEST-UNEXPECTED-FAIL | gtest | timed out after 300 seconds without output
[task 2022-10-25T18:39:02.215Z] 18:39:02     INFO -  mozcrash checking /opt/worker/tasks/task_166672249260018/build/tests/gtest for minidumps...
[task 2022-10-25T18:39:02.215Z] 18:39:02     INFO -  mozcrash INFO | Downloading symbols from: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Mm1pD--kSHCrboCql7iUbg/artifacts/public/build/target.crashreporter-symbols.zip
[task 2022-10-25T18:39:22.382Z] 18:39:22     INFO -  mozcrash INFO | Copy/paste: /opt/worker/tasks/task_166672249260018/fetches/minidump-stackwalk/minidump-stackwalk --symbols-url=https://symbols.mozilla.org/ --human /opt/worker/tasks/task_166672249260018/build/tests/gtest/FD101C90-9AAD-40A6-9A36-85CB3A332285.dmp /var/folders/g7/vplxp93107b0ynpl9047dz78000014/T/tmp906ywwyg
[task 2022-10-25T18:39:30.195Z] 18:39:30     INFO -  mozcrash INFO | Saved minidump as /opt/worker/tasks/task_166672249260018/build/blobber_upload_dir/FD101C90-9AAD-40A6-9A36-85CB3A332285.dmp
[task 2022-10-25T18:39:30.195Z] 18:39:30     INFO -  mozcrash INFO | Saved app info as /opt/worker/tasks/task_166672249260018/build/blobber_upload_dir/FD101C90-9AAD-40A6-9A36-85CB3A332285.extra
[task 2022-10-25T18:39:30.195Z] 18:39:30  WARNING -  PROCESS-CRASH | gtest | application crashed [@ read + 0xa]
[task 2022-10-25T18:39:30.196Z] 18:39:30     INFO -  Crash dump filename: /opt/worker/tasks/task_166672249260018/build/tests/gtest/FD101C90-9AAD-40A6-9A36-85CB3A332285.dmp
[task 2022-10-25T18:39:30.196Z] 18:39:30     INFO -  Operating system: Mac OS X
[task 2022-10-25T18:39:30.196Z] 18:39:30     INFO -                    10.15.7 19H524
[task 2022-10-25T18:39:30.196Z] 18:39:30     INFO -  CPU: amd64
[task 2022-10-25T18:39:30.196Z] 18:39:30     INFO -       family 6 model 158 stepping 10
[task 2022-10-25T18:39:30.196Z] 18:39:30     INFO -       12 CPUs
[task 2022-10-25T18:39:30.197Z] 18:39:30     INFO -  Crash reason:  EXC_SOFTWARE / SIGABRT
[task 2022-10-25T18:39:30.197Z] 18:39:30     INFO -  Crash address: 0x7fff6ddc581e
[task 2022-10-25T18:39:30.197Z] 18:39:30     INFO -  Mac Crash Info:
[task 2022-10-25T18:39:30.197Z] 18:39:30     INFO -  Process uptime: 523 seconds
[task 2022-10-25T18:39:30.197Z] 18:39:30     INFO -  Thread 0 MainThread (crashed)
[task 2022-10-25T18:39:30.198Z] 18:39:30     INFO -   0  libsystem_kernel.dylib!read + 0xa
[task 2022-10-25T18:39:30.198Z] 18:39:30     INFO -       rax = 0x0000000000000004    rdx = 0x0000000000000001
[task 2022-10-25T18:39:30.198Z] 18:39:30     INFO -       rcx = 0x00007ffeeca8f398    rbx = 0x0000000112da9ce0
[task 2022-10-25T18:39:30.198Z] 18:39:30     INFO -       rsi = 0x00007ffeeca8f48f    rdi = 0x0000000000000021
[task 2022-10-25T18:39:30.198Z] 18:39:30     INFO -       rbp = 0x00007ffeeca8f5e0    rsp = 0x00007ffeeca8f398
[task 2022-10-25T18:39:30.199Z] 18:39:30     INFO -        r8 = 0x00000000000130a8     r9 = 0x0000000000000000
[task 2022-10-25T18:39:30.199Z] 18:39:30     INFO -       r10 = 0x93b21e9073cb00f1    r11 = 0x0000000000000206
[task 2022-10-25T18:39:30.199Z] 18:39:30     INFO -       r12 = 0x0000000112da9ce0    r13 = 0x0000000103860670
[task 2022-10-25T18:39:30.199Z] 18:39:30     INFO -       r14 = 0x00007ffeeca8f48f    r15 = 0x0000000103466400
[task 2022-10-25T18:39:30.200Z] 18:39:30     INFO -       rip = 0x00007fff6ddc581e
[task 2022-10-25T18:39:30.200Z] 18:39:30     INFO -      Found by: given as instruction pointer in context
[task 2022-10-25T18:39:30.200Z] 18:39:30     INFO -   1  XUL!testing::internal::ForkingDeathTest::Wait() [gtest-death-test.cc:032a7ecf82a89ad3fcd51243d2c0d1f0c212a577 : 1086 + 0x4]
[task 2022-10-25T18:39:30.200Z] 18:39:30     INFO -       rbp = 0x00007ffeeca8f710    rsp = 0x00007ffeeca8f5f0
[task 2022-10-25T18:39:30.201Z] 18:39:30     INFO -       rip = 0x00000001080a5124
[task 2022-10-25T18:39:30.201Z] 18:39:30     INFO -      Found by: previous frame's frame pointer
[task 2022-10-25T18:39:30.201Z] 18:39:30     INFO -   2  XUL!TestAsyncBlockers_DeregisterEmpty_Test::TestBody() [TestAsyncBlockers.cpp:032a7ecf82a89ad3fcd51243d2c0d1f0c212a577 : 177 + 0x3e]
[task 2022-10-25T18:39:30.201Z] 18:39:30     INFO -       rbx = 0x0000000112da9ce0    rbp = 0x00007ffeeca8f7e0
[task 2022-10-25T18:39:30.201Z] 18:39:30     INFO -       rsp = 0x00007ffeeca8f720    r12 = 0x0000000112da9ce0
[task 2022-10-25T18:39:30.202Z] 18:39:30     INFO -       r13 = 0x0000000103860670    r14 = 0x00000001034c1070
[task 2022-10-25T18:39:30.202Z] 18:39:30     INFO -       r15 = 0x0000000103466400    rip = 0x0000000107e06345
[task 2022-10-25T18:39:30.202Z] 18:39:30     INFO -      Found by: call frame info
[task 2022-10-25T18:39:30.202Z] 18:39:30     INFO -   3  XUL!testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)
[task 2022-10-25T18:39:30.203Z] 18:39:30     INFO -      Found by: inlining
[task 2022-10-25T18:39:30.203Z] 18:39:30     INFO -   4  XUL!testing::Test::Run() [gtest.cc:032a7ecf82a89ad3fcd51243d2c0d1f0c212a577 : 2674 + 0x17]
[task 2022-10-25T18:39:30.203Z] 18:39:30     INFO -       rbx = 0x0000000112da3fa0    rbp = 0x00007ffeeca8f810
[task 2022-10-25T18:39:30.203Z] 18:39:30     INFO -       rsp = 0x00007ffeeca8f7f0    r12 = 0x0000000112da3fa0
[task 2022-10-25T18:39:30.204Z] 18:39:30     INFO -       r13 = 0x0000000103860670    r14 = 0x00000001034c1070
[task 2022-10-25T18:39:30.204Z] 18:39:30     INFO -       r15 = 0x0000000103466400    rip = 0x00000001080b6f19
[task 2022-10-25T18:39:30.204Z] 18:39:30     INFO -      Found by: call frame info
[task 2022-10-25T18:39:30.204Z] 18:39:30     INFO -   5  XUL!testing::TestInfo::Run() [gtest.cc:032a7ecf82a89ad3fcd51243d2c0d1f0c212a577 : 2853 + 0x7]
[task 2022-10-25T18:39:30.204Z] 18:39:30     INFO -       rbx = 0x000000010385e1c0    rbp = 0x00007ffeeca8f850
[task 2022-10-25T18:39:30.205Z] 18:39:30     INFO -       rsp = 0x00007ffeeca8f820    r12 = 0x0000000112da3fa0
[task 2022-10-25T18:39:30.205Z] 18:39:30     INFO -       r13 = 0x0000000103860670    r14 = 0x00000001034c1070
[task 2022-10-25T18:39:30.205Z] 18:39:30     INFO -       r15 = 0x0000000103466400    rip = 0x00000001080b7f09
[task 2022-10-25T18:39:30.205Z] 18:39:30     INFO -      Found by: call frame info
[task 2022-10-25T18:39:30.206Z] 18:39:30     INFO -   6  XUL!testing::TestSuite::Run() [gtest.cc:032a7ecf82a89ad3fcd51243d2c0d1f0c212a577 : 3012 + 0x4]
[task 2022-10-25T18:39:30.206Z] 18:39:30     INFO -       rbx = 0x00000001034c1070    rbp = 0x00007ffeeca8f8a0
[task 2022-10-25T18:39:30.206Z] 18:39:30     INFO -       rsp = 0x00007ffeeca8f860    r12 = 0x0000000000000000
[task 2022-10-25T18:39:30.206Z] 18:39:30     INFO -       r13 = 0x2e8ba2e8ba2e8ba3    r14 = 0x000000010385d280
[task 2022-10-25T18:39:30.207Z] 18:39:30     INFO -       r15 = 0x0000000000000005    rip = 0x00000001080b8a3e
[task 2022-10-25T18:39:30.207Z] 18:39:30     INFO -      Found by: call frame info
[task 2022-10-25T18:39:30.207Z] 18:39:30     INFO -   7  XUL!testing::internal::UnitTestImpl::RunAllTests() [gtest.cc:032a7ecf82a89ad3fcd51243d2c0d1f0c212a577 : 5870 + 0x4]
[task 2022-10-25T18:39:30.207Z] 18:39:30     INFO -       rbx = 0x00000000000000a9    rbp = 0x00007ffeeca8f960
[task 2022-10-25T18:39:30.208Z] 18:39:30     INFO -       rsp = 0x00007ffeeca8f8b0    r12 = 0x0000000103466400
[task 2022-10-25T18:39:30.208Z] 18:39:30     INFO -       r13 = 0x0000000000001b6d    r14 = 0x0000000000000000
[task 2022-10-25T18:39:30.208Z] 18:39:30     INFO -       r15 = 0x0000000103466618    rip = 0x00000001080c752e
[task 2022-10-25T18:39:30.208Z] 18:39:30     INFO -      Found by: call frame info
[task 2022-10-25T18:39:30.209Z] 18:39:30     INFO -   8  XUL!testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)
[task 2022-10-25T18:39:30.209Z] 18:39:30     INFO -      Found by: inlining
[task 2022-10-25T18:39:30.209Z] 18:39:30     INFO -   9  XUL!testing::UnitTest::Run() [gtest.cc:032a7ecf82a89ad3fcd51243d2c0d1f0c212a577 : 5444 + 0x12]
[task 2022-10-25T18:39:30.209Z] 18:39:30     INFO -       rbx = 0x0000000103466400    rbp = 0x00007ffeeca8f9a0
[task 2022-10-25T18:39:30.210Z] 18:39:30     INFO -       rsp = 0x00007ffeeca8f970    r12 = 0x0000000103484be0
[task 2022-10-25T18:39:30.210Z] 18:39:30     INFO -       r13 = 0x0000000000000000    r14 = 0x00000001034665f0
[task 2022-10-25T18:39:30.210Z] 18:39:30     INFO -       r15 = 0x00007ffeeca8fc70    rip = 0x00000001080c6bdf
[task 2022-10-25T18:39:30.210Z] 18:39:30     INFO -      Found by: call frame info
[task 2022-10-25T18:39:30.211Z] 18:39:30     INFO -  10  XUL!RUN_ALL_TESTS() [gtest.h:032a7ecf82a89ad3fcd51243d2c0d1f0c212a577 : 2295]
[task 2022-10-25T18:39:30.211Z] 18:39:30     INFO -      Found by: inlining
[task 2022-10-25T18:39:30.211Z] 18:39:30     INFO -  11  XUL!mozilla::RunGTestFunc(int*, char**) [GTestRunner.cpp:032a7ecf82a89ad3fcd51243d2c0d1f0c212a577 : 167 + 0xc]
[task 2022-10-25T18:39:30.211Z] 18:39:30     INFO -       rbx = 0x00007ffeeca8fa00    rbp = 0x00007ffeeca8fab0
[task 2022-10-25T18:39:30.212Z] 18:39:30     INFO -       rsp = 0x00007ffeeca8f9b0    r12 = 0x0000000103484be0
[task 2022-10-25T18:39:30.212Z] 18:39:30     INFO -       r13 = 0x0000000000000000    r14 = 0x00000001034665f0
[task 2022-10-25T18:39:30.212Z] 18:39:30     INFO -       r15 = 0x00007ffeeca8fc70    rip = 0x0000000108098fb6
[task 2022-10-25T18:39:30.212Z] 18:39:30     INFO -      Found by: call frame info
[task 2022-10-25T18:39:30.213Z] 18:39:30     INFO -  12  XUL!XREMain::XRE_mainStartup(bool*) [nsAppRunner.cpp:032a7ecf82a89ad3fcd51243d2c0d1f0c212a577 : 4771 + 0xf]
[task 2022-10-25T18:39:30.213Z] 18:39:30     INFO -       rbx = 0x00007ffeeca8fc18    rbp = 0x00007ffeeca8fbe0
[task 2022-10-25T18:39:30.213Z] 18:39:30     INFO -       rsp = 0x00007ffeeca8fac0    r12 = 0x0000000103484be0
[task 2022-10-25T18:39:30.213Z] 18:39:30     INFO -       r13 = 0x0000000000000000    r14 = 0x00007ffeeca8fbf0
[task 2022-10-25T18:39:30.213Z] 18:39:30     INFO -       r15 = 0x00007ffeeca8fc70    rip = 0x000000010ce56604
[task 2022-10-25T18:39:30.214Z] 18:39:30     INFO -      Found by: call frame info
[task 2022-10-25T18:39:30.214Z] 18:39:30     INFO -  13  XUL!XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [nsAppRunner.cpp:032a7ecf82a89ad3fcd51243d2c0d1f0c212a577 : 5904 + 0x7]
[task 2022-10-25T18:39:30.214Z] 18:39:30     INFO -       rbx = 0x00007ffeeca8fc18    rbp = 0x00007ffeeca8fc60
[task 2022-10-25T18:39:30.214Z] 18:39:30     INFO -       rsp = 0x00007ffeeca8fbf0    r12 = 0x0000000103484be0
[task 2022-10-25T18:39:30.214Z] 18:39:30     INFO -       r13 = 0x0000000000000000    r14 = 0x00007ffeeca8fdd0
[task 2022-10-25T18:39:30.214Z] 18:39:30     INFO -       r15 = 0x00007ffeeca8fc70    rip = 0x000000010ce5c117
[task 2022-10-25T18:39:30.214Z] 18:39:30     INFO -      Found by: call frame info
[task 2022-10-25T18:39:30.215Z] 18:39:30     INFO -  14  XUL!XRE_main(int, char**, mozilla::BootstrapConfig const&) [nsAppRunner.cpp:032a7ecf82a89ad3fcd51243d2c0d1f0c212a577 : 5972 + 0xf]
[task 2022-10-25T18:39:30.215Z] 18:39:30     INFO -       rbx = 0x0000000000000003    rbp = 0x00007ffeeca8fda0
[task 2022-10-25T18:39:30.215Z] 18:39:30     INFO -       rsp = 0x00007ffeeca8fc70    r12 = 0x00007ffeeca8fc70
[task 2022-10-25T18:39:30.215Z] 18:39:30     INFO -       r13 = 0x0000000000000003    r14 = 0x00007ffeeca8fdd0
[task 2022-10-25T18:39:30.216Z] 18:39:30     INFO -       r15 = 0x00007ffeeca90220    rip = 0x000000010ce5c538
[task 2022-10-25T18:39:30.216Z] 18:39:30     INFO -      Found by: call frame info
[task 2022-10-25T18:39:30.216Z] 18:39:30     INFO -  15  firefox!do_main(int, char**, char**) [nsBrowserApp.cpp:032a7ecf82a89ad3fcd51243d2c0d1f0c212a577 : 226]
[task 2022-10-25T18:39:30.216Z] 18:39:30     INFO -      Found by: inlining
[task 2022-10-25T18:39:30.217Z] 18:39:30     INFO -  16  firefox!main [nsBrowserApp.cpp:032a7ecf82a89ad3fcd51243d2c0d1f0c212a577 : 428 + 0x18a]
[task 2022-10-25T18:39:30.217Z] 18:39:30     INFO -       rbx = 0x00007ffeeca904ec    rbp = 0x00007ffeeca90200
[task 2022-10-25T18:39:30.217Z] 18:39:30     INFO -       rsp = 0x00007ffeeca8fdb0    r12 = 0x0000000103171ced
[task 2022-10-25T18:39:30.217Z] 18:39:30     INFO -       r13 = 0x0000000000000003    r14 = 0x00007ffeeca90220
[task 2022-10-25T18:39:30.217Z] 18:39:30     INFO -       r15 = 0x0000000000000075    rip = 0x0000000103170579
[task 2022-10-25T18:39:30.218Z] 18:39:30     INFO -      Found by: call frame info
[task 2022-10-25T18:39:30.218Z] 18:39:30     INFO -  17  libdyld.dylib!start + 0x0
[task 2022-10-25T18:39:30.218Z] 18:39:30     INFO -       rbx = 0x0000000000000000    rbp = 0x00007ffeeca90210
[task 2022-10-25T18:39:30.218Z] 18:39:30     INFO -       rsp = 0x00007ffeeca90210    r12 = 0x0000000000000000
[task 2022-10-25T18:39:30.218Z] 18:39:30     INFO -       r13 = 0x0000000000000000    r14 = 0x0000000000000000
[task 2022-10-25T18:39:30.219Z] 18:39:30     INFO -       r15 = 0x0000000000000000    rip = 0x00007fff6dc83cc9
[task 2022-10-25T18:39:30.219Z] 18:39:30     INFO -      Found by: call frame info
Flags: needinfo?(lissyx+mozillians)
Flags: needinfo?(lissyx+mozillians)

(In reply to Iulian Moraru from comment #8)

we also got the time out followed by this crash: https://treeherder.mozilla.org/logviewer?job_id=394287507&repo=autoland&lineNumber=11515

The crash reports started because of bug 1797104: Now gtest timeouts trigger and report a crash stack (I hope that's helpful!).

Looks like death gtest is behaving non intuitively on macOS especially in opt and others gtest looks to be avoiding this

Pushed by alissy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/05e994e8e3b5 Add gtest coverage for AsyncBlockers r=nika https://hg.mozilla.org/integration/autoland/rev/5e334e2e3906 Immediately resolve AsyncBlockers when no blocker are registered r=nika

https://hg.mozilla.org/mozilla-central/rev/05e994e8e3b5
https://hg.mozilla.org/mozilla-central/rev/5e334e2e3906

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
Regressions: 1798017
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: