Closed Bug 1792751 Opened 2 years ago Closed 2 years ago

./mach esmify fails if the path contains a dash

Categories

(Core :: General, defect)

defect

Tracking

()

RESOLVED FIXED
107 Branch
Tracking Status
firefox107 --- fixed

People

(Reporter: jdescottes, Assigned: arai)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

STRs:

  • run ./mach esmify --convert remote/webdriver-bidi/

ER:
JSMs should be converted

AR:
No JSM found

I am using hg 6.2, and it seems that remote/webdriver-bidi/ cannot be used as glob syntax. Testing individual commands such as hg files set:glob:remote/webdriver-bidi/**/*.jsm does not return any file, whereas hg files set:glob:remote/webdriver?bidi/**/*.jsm will return all files.

Was not able to escape the - in any way, and in anycase I think esmify still expects the argument to be an actual path, so this might need a fix in the script anyway.

Severity: -- → N/A

I'm not really sure what component this belongs in, but build metadata says esmify belongs to Core :: General, so...

Component: XPConnect → General
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED

hg files 'set:glob:remote/webdriver-bidi/**/*.jsm' doesn't return any file, but hg files 'set:glob:"remote/webdriver-bidi/**/*.jsm"' returns the file list.
So, apparently the pattern needs extra quote.

I'll fix the esmify command to quote the pattern.

Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/afff9a173a44 Quote the mercurial glob pattern in mach esmify command. r=yulia
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: