./mach esmify fails if the path contains a dash
Categories
(Core :: General, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox107 | --- | fixed |
People
(Reporter: jdescottes, Assigned: arai)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
STRs:
- run
./mach esmify --convert remote/webdriver-bidi/
ER:
JSMs should be converted
AR:
No JSM found
I am using hg 6.2, and it seems that remote/webdriver-bidi/
cannot be used as glob syntax. Testing individual commands such as hg files set:glob:remote/webdriver-bidi/**/*.jsm
does not return any file, whereas hg files set:glob:remote/webdriver?bidi/**/*.jsm
will return all files.
Was not able to escape the -
in any way, and in anycase I think esmify
still expects the argument to be an actual path, so this might need a fix in the script anyway.
Reporter | ||
Updated•2 years ago
|
Updated•2 years ago
|
Comment 1•2 years ago
|
||
I'm not really sure what component this belongs in, but build metadata says esmify belongs to Core :: General
, so...
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 2•2 years ago
|
||
hg files 'set:glob:remote/webdriver-bidi/**/*.jsm'
doesn't return any file, but hg files 'set:glob:"remote/webdriver-bidi/**/*.jsm"'
returns the file list.
So, apparently the pattern needs extra quote.
I'll fix the esmify command to quote the pattern.
Assignee | ||
Comment 3•2 years ago
|
||
Comment 5•2 years ago
|
||
bugherder |
Description
•