Closed Bug 1792876 Opened 2 years ago Closed 2 years ago

Active label hidden with MacOS Increase Contrast preference checked

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Version:
Thunderbird 102
Type:
defect

Tracking

(thunderbird_esr102+ fixed, thunderbird106 fixed)

Status:
RESOLVED FIXED
Milestone:
107 Branch
Tracking Flags:
Tracking Status
thunderbird_esr102 + fixed
thunderbird106 --- fixed

People

(Reporter: docorbit, Assigned: Paenglab)

Details

Attachments

(3 files)

220929 Thunderbird increase contrast settings window.png
(deleted), image/png
Details
Bug 1792876 - Don't use special colors on categories in High Contrast mode. r=aleca
(deleted), text/x-phabricator-request
wsmwk
: approval-comm-beta+
Details
1792876-contrast-category-ESR.patch
(deleted), patch
wsmwk
: approval-comm-esr102+
Details | Diff | Splinter Review

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:104.0) Gecko/20100101 Firefox/104.0

Steps to reproduce:

  1. Click Apple menu
  2. Click System Preferences
  3. Click Accessibility
  4. Click Display
  5. Check Increase contrast
  6. Go to Thunderbird 102.3.1
  7. In Thunderbird menu, select Settings
  8. Click Add-ons and themes
  9. Click Recommendations, Extensions or Themes

Actual results:

Whatever you click, the active label is blank

Expected results:

Whatever you click, all labels are readable

Corrected Expected results:

Whatever you click, all labels are readable. The active label has a high-contrast focus indicator such as an outline.

Corrected Expected results:

Whatever you click, all labels are readable. The active label is white text on a dark blue background.

Component: Preferences → Theme
Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
tracking-thunderbird106: ? → ---
tracking-thunderbird_esr102: ? → +
Target Milestone: --- → 107 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/496de8fa4ade
Don't use special colors on categories in High Contrast mode. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED

Comment on attachment 9296785 [details]
Bug 1792876 - Don't use special colors on categories in High Contrast mode. r=aleca

[Approval Request Comment]
User impact if declined: unreadable buttons with macOS High Contrast setting
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be low

Attachment #9296785 - Flags: approval-comm-beta?

[Approval Request Comment]
User impact if declined: unreadable buttons with macOS High Contrast setting
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be low. But this special ESR patch isn't tested.

Attachment #9296862 - Flags: approval-comm-esr102?

Comment on attachment 9296785 [details]
Bug 1792876 - Don't use special colors on categories in High Contrast mode. r=aleca

[Triage Comment]
Approved for beta

Attachment #9296785 - Flags: approval-comm-beta? → approval-comm-beta+
Whiteboard: [TM:102.4.0]
Whiteboard: [TM:102.4.0]

Comment on attachment 9296862 [details] [diff] [review]
1792876-contrast-category-ESR.patch

[Triage Comment]
Approved for esr102

Attachment #9296862 - Flags: approval-comm-esr102? → approval-comm-esr102+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: