Closed Bug 1793730 Opened 2 years ago Closed 2 years ago

Findbar and content moves if there's no search results.

Categories

(Firefox :: Settings UI, defect, P1)

defect

Tracking

()

VERIFIED FIXED
107 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox105 --- unaffected
firefox106 --- unaffected
firefox107 + verified

People

(Reporter: emilio, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image image.png (deleted) —

After bug 1792881, if you find something without result,s the findbar and panel content etc move.

Looking a bit deeper into it I understand the problem now, and bug 1792881 isn't the right fix.

This fixes bug 1792881 in a way that actually preserves behavior from
before bug 1790307.

The main difference between modern flexbox and XUL is that size of
contents outside of the scroller (main-content) affect the size of the
scroller, preventing it from flexing if they're bigger than the
available size.

Instead, preserve the previous behavior (flex the scroller) by
preventing the minimum size from being taken into account, by using
contain. While at it, merge two selectors that were spread out.

Set release status flags based on info from the regressing bug 1792881

Setting to P1 since emilio is on the case.

Severity: -- → S4
Priority: -- → P1

The bug is marked as tracked for firefox107 (nightly). However, the bug still has low severity.

:yshash, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit auto_nag documentation.

Flags: needinfo?(yshash)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9840551d4951 Prevent main pane contents from affecting scroller size. r=Gijs,tgiles,preferences-reviewers
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch

clearing needinfo as this has been closed/fixed

Flags: needinfo?(yshash)
QA Whiteboard: [qa-107b-p2]

I managed to reproduce this issue on a 2022-10-04 Nightly build on macOS 12. Verified as fixed on Firefox 107.0b4(build ID: 20221023190001), Nightly 108.0a1(build ID: 20221023100414) on macOS 12, Windows 10, Ubuntu 22.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: