Closed Bug 1794429 Opened 2 years ago Closed 2 years ago

./mach esmify doesn't update moduleURI/esModuleURI references in actors

Categories

(Core :: General, defect)

Unspecified
All
defect

Tracking

()

RESOLVED INVALID
Tracking Status
firefox107 --- affected

People

(Reporter: Gijs, Unassigned)

References

(Blocks 1 open bug)

Details

When converting actors, the moduleURI property referencing the JSM needs replacing with an esModuleURI property that references the new .sys.mjs. It would be nice if the tool took care of this when updating references.

The moduleURI property is supposed to be updated by the command, in import-to-import_esmodule.js.

Can you provide the example commands that doesn't convert the property?

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to Tooru Fujisawa [:arai] from comment #1)

The moduleURI property is supposed to be updated by the command, in import-to-import_esmodule.js.

Can you provide the example commands that doesn't convert the property?

https://phabricator.services.mozilla.com/D157087#5195919 suggested it didn't there. Is there a different flag you're supposed to use?

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(arai.unmht)

What happened there was the following:

  1. .jsm file is converted to .sys.mjs file with ./mach esmify --convert command
  2. The moduleURI property value is rewritten from .jsm to .sys.mjs manually, according to the comment
  3. ./mach esmify --import command didn't update the property because the property value is already .sys.mjs and it doesn't match the condition to update the property (the property name should be moduleURI and the property value should be .jsm)

if the property value wasn't rewritten to .sys.mjs, ./mach esmify --import command should've updated the property to use esModuleURI and .sys.mjs filename.

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(arai.unmht)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.