./mach esmify doesn't update moduleURI/esModuleURI references in actors
Categories
(Core :: General, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox107 | --- | affected |
People
(Reporter: Gijs, Unassigned)
References
(Blocks 1 open bug)
Details
When converting actors, the moduleURI
property referencing the JSM needs replacing with an esModuleURI
property that references the new .sys.mjs
. It would be nice if the tool took care of this when updating references.
Comment 1•2 years ago
|
||
The moduleURI
property is supposed to be updated by the command, in import-to-import_esmodule.js.
Can you provide the example commands that doesn't convert the property?
Reporter | ||
Comment 2•2 years ago
|
||
(In reply to Tooru Fujisawa [:arai] from comment #1)
The
moduleURI
property is supposed to be updated by the command, in import-to-import_esmodule.js.Can you provide the example commands that doesn't convert the property?
https://phabricator.services.mozilla.com/D157087#5195919 suggested it didn't there. Is there a different flag you're supposed to use?
Comment 3•2 years ago
|
||
What happened there was the following:
.jsm
file is converted to.sys.mjs
file with./mach esmify --convert
command- The
moduleURI
property value is rewritten from.jsm
to.sys.mjs
manually, according to the comment ./mach esmify --import
command didn't update the property because the property value is already.sys.mjs
and it doesn't match the condition to update the property (the property name should bemoduleURI
and the property value should be.jsm
)
if the property value wasn't rewritten to .sys.mjs
, ./mach esmify --import
command should've updated the property to use esModuleURI
and .sys.mjs
filename.
Description
•