Closed
Bug 1794773
Opened 2 years ago
Closed 2 years ago
gDevTools.showToolbox should wait for toolbox to be "raised"
Categories
(DevTools :: Framework, defect, P3)
DevTools
Framework
Tracking
(firefox108 fixed)
RESOLVED
FIXED
108 Branch
| Tracking | Status | |
|---|---|---|
| firefox108 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
I used bug 1794769 to debug this race condition which was making devtools/client/styleeditor/test/browser_styleeditor_syncAddProperty.js to fail with patches from bug 1794693.
In that patch, I'm probably introducing some slight change in execution order and make this test to fail because a previous call to gDevTools.showToolbox is late focusing the toolbox tab.
And as this test is opening many tabs and toolboxes, we end up focusing a previous tab.
This issue comes from this code:
https://searchfox.org/mozilla-central/rev/e94c6cb9649bfe4e6a3888460f41bcd4fe30a6ca/devtools/client/framework/toolbox.js#3218-3220
which sends an async event and we never wait for its completion.
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
|
||
Updated•2 years ago
|
Severity: -- → S3
Priority: -- → P3
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9e87a8d845c5
[devtools] gDevTools.showToolbox should wait for toolbox to be "raised". r=jdescottes
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox108:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•