Closed Bug 1795047 Opened 2 years ago Closed 2 years ago

Power usage feature should inform users that x86_64 Linux is supported

Categories

(Core :: Gecko Profiler, task, P1)

task

Tracking

()

RESOLVED FIXED
108 Branch
Tracking Status
relnote-firefox --- 107+
firefox107 + fixed
firefox108 --- fixed

People

(Reporter: dlrobertson, Assigned: florian)

References

Details

Attachments

(2 files, 1 obsolete file)

The power use feature states:

Record the value of every energy meter available on the system with each sample. Only available on Windows 11 and Apple Silicon.

It should also include Linux x86_64 as a supported environment.

I'm adding support for x86_64 Macs too in bug 1795171. The string freeze starts on October 14 (today or tomorrow depending on your timezone), so we should probably hurry up on this bug if we want to have the description fixed at the same time the feature ships.

(In reply to Florian Quèze [:florian] from comment #1)

I'm adding support for x86_64 Macs too in bug 1795171. The string freeze starts on October 14 (today or tomorrow depending on your timezone), so we should probably hurry up on this bug if we want to have the description fixed at the same time the feature ships.

Good point! I'll post a patch tonight.

The profiler Power feature is now supported on Linux (x86_64). The feature
string should indicate this.

Assignee: nobody → drobertson
Status: NEW → ASSIGNED
Severity: -- → N/A
Priority: -- → P3

[Tracking Requested - why for this release]: Bug 1794327 and bug 1795171 added in 107 features that are release-note worthy, so we should clarify the help messages in 107. Thankfully these strings aren't localized so the patch should be easy to uplift.

:florian in comment 5 you mention "release note worthy", could you nominate those for release notes?
https://wiki.mozilla.org/Release_Management/Release_Notes#How_to_nominate_a_bug_for_release_notes_addition.3F

Flags: needinfo?(florian)
Attachment #9298553 - Attachment is obsolete: true

The bug is marked as tracked for firefox107 (beta). However, the bug still has low priority.

:plawless, could you please increase the priority for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit auto_nag documentation.

Flags: needinfo?(plawless)
Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/94963e082433 Power use feature string should clarify what's available on each platform, r=canaltinova,dlrobertson.

I put P3 initially to this bug thinking that this is mostly about documentation but it's actually the last bug of the series of bugs for shipping power profiling and we would like to ship it in the next release. Bumping it to P1.

Flags: needinfo?(plawless)
Priority: P3 → P1

Backed out for causing mochitest failures on performance-new/utils.js

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/siteIdentity/browser_check_identity_state.js | uncaught exception - SyntaxError: export declarations may only appear at top level of a module at @resource://devtools/client/performance-new/utils.js:14:34
Flags: needinfo?(drobertson)
Assignee: drobertson → florian
Flags: needinfo?(drobertson)
Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fe7129ced28e Power use feature string should clarify what's available on each platform, r=canaltinova,dlrobertson.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch

:florian please submit a beta uplift request when ready

Release Note Request (optional, but appreciated)
[Why is this notable]: Firefox 104 shipped support for Power profiling on Windows 11 on Intel CPUs and Apple Silicon. We were asked about other platforms.
[Affects Firefox for Android]: no
[Suggested wording]: Power profiling is now also supported on Linux and Mac with Intel CPUs, in addition to Windows 11 and Apple Silicon.
[Links (documentation, blog post, etc)]:

relnote-firefox: --- → ?
Attached patch Patch for beta (deleted) — Splinter Review

Approval Request Comment
[Feature/Bug causing the regression]: The documentation changes for bug 1794327 and bug 1795171 haven't landed in time.
[User impact if declined]: Confusing description of the "Power Use" profiler feature.
[Is this code covered by automated tests?]: Not directly, but about:profiling has some test coverage so tests will be orange if we break it entirely with a bad merge.
[Has the fix been verified in Nightly?]: about:profiling looks correct to me on today's nightly (I looked at it on Windows 11, a macbook, and ubuntu).
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Not really.
[Why is the change risky/not risky?]: things that could break are very likely to be caught by CI.
[String changes made/needed]: Use visible strings are changed, but these strings are not localized, so uplifting should not be a problem.

Flags: needinfo?(florian)
Attachment #9299897 - Flags: review+
Attachment #9299897 - Flags: approval-mozilla-beta?

Comment on attachment 9299897 [details] [diff] [review]
Patch for beta

Approved for 107.0b5.

Attachment #9299897 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: