Closed
Bug 1795362
Opened 2 years ago
Closed 2 years ago
ESLint rule mozilla/valid-services-property errors in AboutCompat.jsm
Categories
(Web Compatibility :: Tooling & Investigations, task)
Web Compatibility
Tooling & Investigations
Tracking
(firefox107 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox107 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
AboutCompat.jsm currently references Services.scriptSecurityManager.createCodebasePrincipal which is obsolete, however I would assume it is left there because it is a fallback mechanism for older Firefox versions.
We therefore can add an exception for the rule.
Note this rule is not enabled by default, but needs to be run on a full Firefox build with via:
MOZ_OBJDIR=<objdir> ./mach eslint --rule "mozilla/valid-services-property: error" *
|
Assignee | |
Comment 1•2 years ago
|
||
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6953d8ab7767
Ignore ESLint rule valid-services-property in fallback code in AboutCompat.jsm. r=webcompat-reviewers,denschub
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•