Closed Bug 1796590 Opened 2 years ago Closed 2 years ago

Perma reftest TEST-UNEXPECTED-PASS | css-grid/grid-item-video-stretch-001.html == css-grid/grid-item-video-stretch-001-ref.html | image comparison, max difference: 0, number of differing pixels: 0

Categories

(Core :: Layout, defect, P5)

defect

Tracking

()

RESOLVED FIXED
108 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox106 --- unaffected
firefox107 --- unaffected
firefox108 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: dholbert)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

And also this: https://treeherder.mozilla.org/logviewer?job_id=393808247&repo=mozilla-central might be caused by the same Bug.
Failure line: REFTEST TEST-UNEXPECTED-PASS | dom/media/test/reftest/color_quads/720p.png.bt709.bt709.pc.yuv420p.vp9.webm == dom/media/test/reftest/color_quads/720p.png.bt709.bt709.pc.yuv420p.av1.webm | image comparison, max difference: 16, number of differing pixels: 1874

Backfill link: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&tochange=67ab7c3f34435806d010d5e06bc20088af73c05b&fromchange=bdf51a01a2e1b343cafff08d4847e869ff76b9c9&searchStr=os%2Cx%2C11%2Cwebrender%2Cshippable%2Copt%2Creftests%2Ctest-macosx1100-64-shippable-qr%2Fopt-reftest%2Cr&selectedTaskRun=e4tHxBFDTAe7OFqih337yA.0

Regressed by: 1792257

Set release status flags based on info from the regressing bug 1792257

:az, since you are the author of the regressor, bug 1792257, could you take a look?

For more information, please visit auto_nag documentation.

Flags: needinfo?(azebrowski)
Keywords: regression

Thanks -- I'm looking into it but haven't been able to repro locally yet. Should have more to report this week.

Sounds like maybe we just need to remove or update the fuzzy annotation, to reflect the fact that this test is always passing (or sometimes-passing, if it's not 100%) on this platform? [EDIT: Looks like this is indeed always-passing, per the bug title and the perma-orange on recent history at https://treeherder.mozilla.org/jobs?repo=mozilla-central&searchStr=macosx11%2Cr6 .]

The test is currently annotated as fuzzy-if(appleSilicon,255-255,167058-167058) which essentially means "Expected to catastrophically fail" (expecting 167,058 pixels to always differ between testcase & reference case). That annotation was added as part of bug 1706716, which was a broad "annotate all the existing failures on this platform, to reflect reality" sort of patch.

Probably those mismatching pixels were just all of the video areas failing to render at all, and probably that was fixed (partly or entirely) by bug 1792257?

Looks like this test used to catastrophically fail on this platform, per this
annotation; and that failure seems to have been fixed by bug 1792257.

Here's a try run with all macos11 reftest tasks, with the fuzzy annotation removed, just to be sure this test really does pass on all variants of this task on this platform:
https://treeherder.mozilla.org/jobs?repo=try&revision=98518b95349740a84f1270e6a351aaf5c910e4f2

Assignee: nobody → dholbert
Flags: needinfo?(azebrowski)
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/780d2d1d736f Remove fuzzy-if(appleSilicon) annotation for css-grid/grid-item-video-stretch-001.html. (no review, just updating reftest manifest to reflect reality)
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: