Firefox View should send telemetry for 0 tabs when there are devices
Categories
(Firefox :: Firefox View, defect)
Tracking
()
People
(Reporter: Gijs, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fidefe-firefox-view])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
dmeehan
:
approval-mozilla-beta+
|
Details |
To help work out with assessing the impact of bug 1792040 it would be useful if we had telemetry for the case of not having any tabs synced in despite having more than 1 connected device. This early return is stopping that from happening right now.
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Comment 3•2 years ago
|
||
bugherder |
Assignee | ||
Comment 4•2 years ago
|
||
Comment on attachment 9300452 [details]
Bug 1797540 - Firefox View should send telemetry for 0 tabs as well, r?sclements,niklas
Beta/Release Uplift Approval Request
- User impact if declined: None. Impact to our telemetry: we can't see how many people are having issues with fxview showing 0 tabs
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce: N/A
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): It's a simple telemetry recording addition that doesn't otherwise impact users.
- String changes made/needed: Nope
- Is Android affected?: No
Comment 5•2 years ago
|
||
Comment on attachment 9300452 [details]
Bug 1797540 - Firefox View should send telemetry for 0 tabs as well, r?sclements,niklas
Approved for 107.0b8.
Comment 6•2 years ago
|
||
bugherder uplift |
Updated•2 years ago
|
Updated•2 years ago
|
Comment 7•2 years ago
|
||
Hi, Gijs, does this patch require manual verification from QA? If so, can you please give us some details about what needs to be tested?
Assignee | ||
Comment 8•2 years ago
|
||
(In reply to Ciprian Georgiu [:ciprian_georgiu], Release Desktop QA from comment #7)
Hi, Gijs, does this patch require manual verification from QA? If so, can you please give us some details about what needs to be tested?
I'm not sure about "require", but I guess it would be useful. In the scenario described in https://bugzilla.mozilla.org/show_bug.cgi?id=1792040#c13 , I would expect that about:telemetry
lists a firefoxview - synced_tabs - tabs
event with count: 0
as the object value. Does that help?
Comment 9•2 years ago
|
||
I have verified this issue using the latest Firefox Beta 107.0b9 (Build ID: 20221103190044) and Firefox Nightly 108.0a1 (Build ID: 20221106212619) on Windows 10x64, macOS 12.6 and Linux Mint 20.2 and I can confirm the following:
- A "synced_tabs" with "count: "0"" telemetry event is generated on the "about:telemetry#events-tab" page for the case of not having any tabs to sync.
Comment 10•2 years ago
|
||
Thanks, Alice and Gijs!
Description
•