Closed Bug 1797540 Opened 2 years ago Closed 2 years ago

Firefox View should send telemetry for 0 tabs when there are devices

Categories

(Firefox :: Firefox View, defect)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
108 Branch
Tracking Status
firefox107 --- verified
firefox108 --- verified

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-firefox-view])

Attachments

(1 file)

To help work out with assessing the impact of bug 1792040 it would be useful if we had telemetry for the case of not having any tabs synced in despite having more than 1 connected device. This early return is stopping that from happening right now.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/32bb15fcb015 Firefox View should send telemetry for 0 tabs as well, r=sclements
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch

Comment on attachment 9300452 [details]
Bug 1797540 - Firefox View should send telemetry for 0 tabs as well, r?sclements,niklas

Beta/Release Uplift Approval Request

  • User impact if declined: None. Impact to our telemetry: we can't see how many people are having issues with fxview showing 0 tabs
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: N/A
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It's a simple telemetry recording addition that doesn't otherwise impact users.
  • String changes made/needed: Nope
  • Is Android affected?: No
Attachment #9300452 - Flags: approval-mozilla-beta?

Comment on attachment 9300452 [details]
Bug 1797540 - Firefox View should send telemetry for 0 tabs as well, r?sclements,niklas

Approved for 107.0b8.

Attachment #9300452 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Hi, Gijs, does this patch require manual verification from QA? If so, can you please give us some details about what needs to be tested?

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to Ciprian Georgiu [:ciprian_georgiu], Release Desktop QA from comment #7)

Hi, Gijs, does this patch require manual verification from QA? If so, can you please give us some details about what needs to be tested?

I'm not sure about "require", but I guess it would be useful. In the scenario described in https://bugzilla.mozilla.org/show_bug.cgi?id=1792040#c13 , I would expect that about:telemetry lists a firefoxview - synced_tabs - tabs event with count: 0 as the object value. Does that help?

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(ciprian.georgiu)

I have verified this issue using the latest Firefox Beta 107.0b9 (Build ID: 20221103190044) and Firefox Nightly 108.0a1 (Build ID: 20221106212619) on Windows 10x64, macOS 12.6 and Linux Mint 20.2 and I can confirm the following:

  • A "synced_tabs" with "count: "0"" telemetry event is generated on the "about:telemetry#events-tab" page for the case of not having any tabs to sync.
Status: RESOLVED → VERIFIED
Flags: qe-verify+

Thanks, Alice and Gijs!

QA Whiteboard: [qa-triaged]
Flags: needinfo?(ciprian.georgiu)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: