Ensure container queries make forward progress (with scrollbars / pseudos)
Categories
(Core :: CSS Parsing and Computation, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox110 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
Crash Data
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
There are a few tests that time out infinite-looping because we don't find a stable layout. We should make sure we only make forward progress.
|
||
Comment 1•2 years ago
|
||
(emilio noted that this is related to https://github.com/w3c/csswg-drafts/issues/7875 )
|
||
Comment 2•2 years ago
|
||
The severity field is not set for this bug.
:jfkthame, could you have a look please?
For more information, please visit auto_nag documentation.
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 3•2 years ago
|
||
Instead of keeping a set of frames to update, keep a depth-ordered frame
list. Factor out the DirtyRootList for this.
Make sure that we're updating ancestor containers before children, and
make sure to store the last container state even if we end up not
updating (due to the element being in mUpdatedContainerQueryContents),
so that following layouts are stable.
This fixes the timeout in inline-size-bfc-floats, and the same kind of
instability in auto-scrollbars.html (if you take a profile of that test
you can see us infinitely recursing), as well as fixing various other
tests.
It causes a regression in nested-query-containers.html, probably to do with
ib-splits (since it's a block inside an inline and so on, and the frame
tree depth doesn't match the content tree depth, most likely). That
might need extra tweaks but it doesn't seem terribly concerning, so I'd
rather get this in.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/52076feb5b59 Make sure container queries make forward progress. r=Oriol
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/674c4b734b8c Fix a comment as per review feedback that I missed.
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/52076feb5b59
https://hg.mozilla.org/mozilla-central/rev/674c4b734b8c
|
|
||
Comment 8•2 years ago
|
||
Copying crash signatures from duplicate bugs.
Description
•