Closed
Bug 17978
Opened 25 years ago
Closed 2 years ago
CSS2 System Colors don't refresh with System Changes
Categories
(Core :: Layout, defect, P3)
Core
Layout
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: tekhir, Unassigned)
References
Details
(Keywords: platform-parity)
Attachments
(1 file)
(deleted),
text/html
|
Details |
Steps to Reproduce:
1.) Set a html tag or a XUL style to use any of the system colors from CSS2.
Example: body { background-color: background; }
2.) View in Mozilla
3.) Change system colors
Actual Result:
The webpage/xul keep previous colors.
Expected Result:
When the system colors change it should force Mozilla to repaint everything
which uses these CSS2 colors (xul, html)
Build Date & Platform:
1999-11-01-09-M11 build for Win95 (checked Apprunner)
Updated•25 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M15
Comment 2•25 years ago
|
||
Pushing my M15 bugs to M16
Comment 3•25 years ago
|
||
I guess it's a GFX or maybe a Widget problem on Windows. On Mac when you change
something in the Appearance control panel, the OS causes an update in all the
windows. Reassigned to hyatt.
Assignee: pierre → hyatt
Status: ASSIGNED → NEW
Component: Style System → XP Toolkit/Widgets
Keywords: pp
Comment 4•25 years ago
|
||
Need ot listen to sysinfo changed message on windows and update the look and
feel object and invalidate all windows.
Assignee: hyatt → rods
Comment 5•25 years ago
|
||
I don't think invalidating all the window is enough. It seems to Kevin and
myself that we may need to re-resolve style. Pierre, what do you think?
Status: NEW → ASSIGNED
Comment 6•25 years ago
|
||
Correct: the color is stored as an identifier (eg. eCSSKeyword_appworkspace) in
the CSSDeclaration but it gets converted to an RGB value when we map it into the
style context. To re-resolve style, you may have to do the same thing as
nsPresContext::PreferenceChanged().
Comment 7•25 years ago
|
||
It would be nice to have a XP mechanism to re-resolve style on all the windows.
It will be triggered by the "sysinfo changed" message on Windows and the
Appearance Manager Apple Events on the Mac. When you are done on Windows, please
reassign to pinkerton and pavlov.
Also, IMHO if it's not trivial, feel free to postpone the bug.
Comment 11•24 years ago
|
||
This bug is marked "future" because it is not critical for RTM (Release To
Manufacturing). If anyone believes it is critical, please explain why in
this bug.
Target Milestone: M18 → Future
Comment 12•24 years ago
|
||
*** Bug 49170 has been marked as a duplicate of this bug. ***
Comment 13•24 years ago
|
||
Tested on Win95 with 10_02_09_mn6 build. Created a testcase (attached) using
background-color: background on BODY element as indicated in 'Steps to
Reproduce'. Viewed in Netscape6, then changed system colors adn reloaded.
Background color was updated. WORKSFORME.
Comment 14•24 years ago
|
||
Comment 16•24 years ago
|
||
Netscape's standard compliance QA team reorganised itself once again, so taking
remaining non-tables style bugs. Sorry about the spam. I tried to get this done
directly at the database level, but apparently that is "not easy because of the
shadow db", "plus it screws up the audit trail", so no can do...
QA Contact: chrisd → ian
Comment 17•24 years ago
|
||
I'm not sure if this is the same problem but Mozilla using the Classic theme
doesn't recolor when system colors change under Windows. New windows appear in
new colors but parts of old windows don't change the colors at all. Tested with
0.8.
Menu colors (eg File menu) are even remembered per window (I expect only one
file menu should exist in the whole app, that's probably where all the memory is
eaten).
To reproduce:
1)run Mozilla under windows and select the classic skin.
2) pull down the file menu
3) change the system colors (of 3d objects)
4) resize the browser window and open new browser window
5) pull down the file menus and edit menus in both windows
[6) change the system colors to somethig else again
7) resize the second window and open new browser
8) pull down file, edit and view menus in all three windows]
Result: Enjoying a colorful Mozilla
Expected: All controls should appear in the new colors.
Comment 18•24 years ago
|
||
I'm not sure if this is the same problem but Mozilla using the Classic theme
doesn't recolor when system colors change under Windows. New windows appear in
new colors but parts of old windows don't change the colors at all. Tested with
0.8.
Menu colors (eg File menu) are even remembered per window (I expect only one
file menu should exist in the whole app, that's probably where all the memory is
eaten).
To reproduce:
1)run Mozilla under windows and select the classic skin.
2) pull down the file menu
3) change the system colors (of 3d objects)
4) resize the browser window and open new browser window
5) pull down the file menus and edit menus in both windows
[6) change the system colors to somethig else again
7) resize the second window and open new browser
8) pull down file, edit and view menus in all three windows]
Result: Enjoying a colorful Mozilla
Expected: All controls should appear in the new colors.
Comment 19•24 years ago
|
||
Experienced similar problem on Linux: when the GTK theme is canged using the
gnomecc configuration tool, all native GTK apps redraw themselves using the new
settings but mozilla has to be restarted. I tested with 0.8 I think.
Updated•24 years ago
|
Target Milestone: --- → mozilla1.2
Updated•23 years ago
|
Priority: P3 → P2
Target Milestone: mozilla1.2 → Future
Comment 20•22 years ago
|
||
*** Bug 186411 has been marked as a duplicate of this bug. ***
Comment 21•21 years ago
|
||
i'm bouncing this randomly.
there are three possible reasons this isn't working (and i'm in a hurry, i'll
shoot now and check later).
A. System Colors Change
1. widget/gfx don't get a message from the system
2. widget/gfx get the message and don't send it anywhere
B. Colors in edit>preferences>appearance>colors change
Accused problem based on B:
presshell or whatever aren't registered to be informed about color changes
Assignee: rods → nobody
Status: ASSIGNED → NEW
Component: XP Toolkit/Widgets → Layout
OS: Windows 95 → All
QA Contact: ian → core.layout
Hardware: PC → All
Target Milestone: Future → ---
Comment 22•18 years ago
|
||
WFM
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061206 Minefield/3.0a1
Comment 23•17 years ago
|
||
This is WFM on Windows XP SR-2 using
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070622 ID:2007062204
-> WORKSFORME
Comment 24•16 years ago
|
||
Fixed on Windows by bug 143174.
Should be tested on other platforms, but probably covered by theme change notifications on GTK.
Somebody should check Mac, though.
Comment 25•16 years ago
|
||
Actually, I think it doesn't work on GTK; native theme elements get changed, but not system colors (which are presumably cached somewhere).
We may want to split this into separate bugs per-platform, though.
Comment 27•6 years ago
|
||
Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information
Priority: P2 → P3
Updated•2 years ago
|
Severity: normal → S3
Comment 28•2 years ago
|
||
The severity field for this bug is relatively low, S3. However, the bug has 4 duplicates.
:dholbert, could you consider increasing the bug severity?
For more information, please visit auto_nag documentation.
Flags: needinfo?(dholbert)
Comment 29•2 years ago
|
||
Pretty sure this is fixed now.
Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(dholbert)
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•