Closed
Bug 1798861
Opened 2 years ago
Closed 2 years ago
Make SearchSuggestionController track a single context object
Categories
(Firefox :: Search, task, P5)
Firefox
Search
Tracking
()
RESOLVED
FIXED
108 Branch
| Tracking | Status | |
|---|---|---|
| firefox108 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
While looking into bug 1429108 I noticed an intermittent TV failure in test_searchSuggest.js that made me look into the suggestions controller. I noticed we track too many details at the controller level, that may easily cause race conditions.
Now, I don't know if this is going to fix the intermittent, but it seems to make sense to ensure there's only one context object tracking each query (like in the urlbar) and most functions just receive or use that object.
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
it doesn't solve the TV failure anyway, just saw it on Try. For that we'll need the logging from bug 1798869
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/cb4f89dcd7fc
Make SearchSuggestionController track a single context object. r=Standard8
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox108:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•