Closed
Bug 1799212
Opened 2 years ago
Closed 2 years ago
Escape key does not exit screenshots tool when focused on Save visible/Save full page buttons (component)
Categories
(Firefox :: Screenshots, defect, P2)
Firefox
Screenshots
Tracking
()
VERIFIED
FIXED
109 Branch
People
(Reporter: tgiles, Assigned: niklas)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
STR
- Set screenshots.browser.component.enabled to true
- Navigate to https://bugzilla.mozilla.org/home (or any webpage)
- Use keyboard shortcut (Ctrl + Shift + S on Windows, not sure on Mac or Linux) to take a screenshot
- Use F6 to cycle to the Save visible/Save full page buttons
- Hit Escape key to cancel screenshot
Expected:
- Screenshot is cancelled when ESC key is pressed
Actual:
- Nothing happens
This is based on the expectation from the previous extension implementation
|
||
Comment 1•2 years ago
|
||
The extension's UI does get dismissed using Escape when the focus is on either the Save visible or Save full page button, so this would represent a regression if we flip the pref.
Severity: -- → S3
Priority: -- → P2
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → nbaumgardner
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•2 years ago
|
||
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6b4aaee5d13c
Escape screenshots when panel is focused. r=sfoster
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox109:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
|
||
Updated•2 years ago
|
Flags: qe-verify+
|
||
Comment 5•2 years ago
|
||
Reproducible on a 2022-11-04 Nightly build on Windows 10.
Verified as fixed on Firefox 109.0b4(build ID: 20221218190303) and Nightly 110.0a1(build ID: 20221218193142) on Windows 10, macOS 12, Ubuntu 22.
You need to log in
before you can comment on or make changes to this bug.
Description
•