Avoid asyncLoadDB to run late in shutdown
Categories
(Toolkit :: Add-ons Manager, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox112 | --- | fixed |
People
(Reporter: jstutte, Assigned: jstutte)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
The pref extensions.pendingOperations
is writtent late during shutdown, asyncLoadDB
probably should check for shutdown?
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
PIProvider already uses AsyncShutdown.quitApplicationGranted to start its shutdown. But it should also check to not be instantiated anymore after we passed that barrier. And XPIDatabase should check XPIProvider for shutdown beofre attempting to load a database, too., too.
Updated•2 years ago
|
Comment 3•2 years ago
|
||
Backed out changeset e8699d44117a (Bug 1799421) for marionette failures on nsDebugImpl.cpp.
Backout link
Push with failures <--> Mn
Failure Log
Assignee | ||
Comment 4•2 years ago
|
||
Yeah, apparently asyncLoadDB
needs to do
lazy.XPIInternal.resolveDBReady(this._dbPromise);
before returning in order to not block.
But the interesting piece is that we hit this at all in CI. I assume that indicates that the AddonManager
can be starting late in shutdown. That reminds me of bug 1814104. If the test passes now we can probably file a new bug for this (or even ignore it).
Assignee | ||
Comment 5•2 years ago
|
||
Hopefully that regression will be addressed by the latest change, too.
Assignee | ||
Comment 7•2 years ago
|
||
Comment 9•2 years ago
|
||
bugherder |
Comment 10•2 years ago
|
||
bugherder |
Description
•