Closed
Bug 1799971
Opened 2 years ago
Closed 2 years ago
Use signal handling for null pointer checks of GC objects in baseline
Categories
(Core :: JavaScript: WebAssembly, enhancement, P2)
Core
JavaScript: WebAssembly
Tracking
()
RESOLVED
FIXED
109 Branch
Tracking | Status | |
---|---|---|
firefox109 | --- | fixed |
People
(Reporter: rhunt, Assigned: yury)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
We should see if we can eliminate our null-checks for GC operations using our signal handling mechanism.
We currently do something similar to this for call_indirect, where the function we're calling will have InstanceReg = null when the function pointer is null. So we mark the instruction to load the HeapReg from InstanceReg as a potentially trapping instruction [1].
I believe we can just do a similar thing for most of our GC instructions. For all of them we need to emit the trap metadata immediately before the first load that would be done on a potentially null pointer.
Assignee | ||
Updated•2 years ago
|
Assignee: nobody → ydelendik
Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Attachment #9303354 -
Attachment description: WIP: Bug 1799971 - Use signal for null GC references checks. → Bug 1799971 - Use signal for null GC references checks. r?rhunt
Comment 2•2 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox109:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
Reporter | ||
Updated•2 years ago
|
Summary: Use signal handling for null pointer checks of GC objects → Use signal handling for null pointer checks of GC objects in baseline
You need to log in
before you can comment on or make changes to this bug.
Description
•