Open
Bug 1800040
Opened 2 years ago
Updated 2 years ago
Only bail from Custom Formatter hooks if calling effectul native functions
Categories
(DevTools :: Framework, task)
DevTools
Framework
Tracking
(Not tracked)
NEW
People
(Reporter: nchevobbe, Unassigned)
References
(Blocks 1 open bug)
Details
While checking our current implementation against ClojureScript custom formatters, we found out that the hooks were bailing out because of our use of makeSideeffectFreeDebugger
.
It turns out the tools are declaring and setting global variables, which is considered effectful.
Since this is behind a pref, we can probably accept such impact, while still preventing native functions to be called.
Reporter | ||
Updated•2 years ago
|
Type: defect → task
You need to log in
before you can comment on or make changes to this bug.
Description
•