Click listeners should not fire when a form-associate custom element is disabled
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Tracking
()
People
(Reporter: web, Assigned: edgar)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:106.0) Gecko/20100101 Firefox/106.0
Steps to reproduce:
Given a form-associate custom element with a click listener, those listener callbacks should not run on click when the element matches :disabled
for example, an <x-checkbox>
(see attached) which toggle's it's checked
attribute and sets form state when clicked should not run it's private #onClick
listener when it's containing fieldset has the disabled
attribute. Compare with Chromium's behaviour.
Actual results:
Click listeners ran
Expected results:
Click listeners should not run
Comment 1•2 years ago
|
||
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:106.0) Gecko/20100101 Firefox/106.0
Hi,
I am able to reproduce the issue in release 106.0.5, beta 107.0 and the latest nightly 108.0a1 (2022-11-14) on Windows 10 as well.
Not a regression since in the older Fx versions the <x-checkbox> is not displayed at all, and until then, the issue is reproducible in all Fx versions tested.
Thanks for your input.
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 2•2 years ago
|
||
Comment 5•2 years ago
|
||
Backed out for causing failures on /disabled-event-dispatch.tentative.html
- backout: https://hg.mozilla.org/integration/autoland/rev/80698a53532d599892142683fd06f8fcb5557b9c
- push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=7aeaa20a812df8716b9f9c7e3b8efeffcd17962a
- failure seen on: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&searchStr=os%2Cx%2C10.15%2Cwebrender%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-macosx1015-64-qr%2Fopt-web-platform-tests%2Cwpt1&revision=9e43fdab823849d9f8e3cc4176504fd28234f106
- failure log: https://treeherder.mozilla.org/logviewer?job_id=401294469&repo=autoland&lineNumber=8648
[task 2023-01-04T02:59:19.889Z] 02:59:19 INFO - TEST-PASS | /html/semantics/disabled-elements/disabled-event-dispatch.tentative.html | Testing click events when clicking child of disabled my-control.
[task 2023-01-04T02:59:19.889Z] 02:59:19 INFO - TEST-UNEXPECTED-TIMEOUT | /html/semantics/disabled-elements/disabled-event-dispatch.tentative.html | Testing click events when clicking disabled button. - Test timed out
[task 2023-01-04T02:59:19.890Z] 02:59:19 INFO -
[task 2023-01-04T02:59:19.890Z] 02:59:19 INFO - TEST-UNEXPECTED-NOTRUN | /html/semantics/disabled-elements/disabled-event-dispatch.tentative.html | Testing click events when clicking disabled my-control. - expected PASS
[task 2023-01-04T02:59:19.891Z] 02:59:19 INFO - TEST-UNEXPECTED-TIMEOUT | /html/semantics/disabled-elements/disabled-event-dispatch.tentative.html | expected OK
[task 2023-01-04T02:59:19.891Z] 02:59:19 INFO - TEST-INFO took 10704ms
Assignee | ||
Comment 7•2 years ago
|
||
Okay, adding new tests seems make the wpt timed out, probably need to mark it requiring longer timeout value.
https://treeherder.mozilla.org/jobs?repo=try&revision=8f50b5588df8b08012539b1b9334602b1e92d629
Comment 9•2 years ago
|
||
bugherder |
Updated•2 years ago
|
Comment 11•2 years ago
|
||
Verified - Fixed in latest Nightly 110.0a1 (2023-01-06) using Windows 10, macOS 12 and Ubuntu 20.
Description
•