Never throttle crashes involving the PHC
Categories
(Socorro :: Antenna, task, P2)
Tracking
(Not tracked)
People
(Reporter: gsvelto, Assigned: willkg)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
PHC crashes are very valuable because they involve very dangerous and exploitable scenarios: buffer overruns, use-after-frees, etc... We only get a trickle of them because of the statistical nature of PHC.
Currently PHC is only enabled on nightly so related crashes are not throttled, however we want to use it more aggressively in the future, potentially shipping it in release. When that happens we should tweak the throttling logic to never throttle crashes that have the PHCKind
annotation set.
There's no hurry to implement this because it's still some time off but filing this bug nonetheless so I don't forget.
Assignee | ||
Comment 1•2 years ago
|
||
How can we know whether a crash report involves PHC?
Reporter | ||
Comment 2•2 years ago
|
||
They have the PHCKind
annotation set, non-PHC crashes don't have it.
Assignee | ||
Comment 3•2 years ago
|
||
I can get this done today.
Assignee | ||
Comment 4•2 years ago
|
||
Assignee | ||
Comment 5•2 years ago
|
||
Assignee | ||
Comment 6•2 years ago
|
||
I deployed this just no in bug #1800935. Marking as FIXED.
Description
•