Closed Bug 1801051 Opened 2 years ago Closed 2 years ago

Remove cookies migration (except for FirefoxProfileMigrator)

Categories

(Firefox :: Migration, enhancement)

Firefox 109
Desktop
All
enhancement

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox107 --- unaffected
firefox108 --- unaffected
firefox109 --- wontfix
firefox110 --- wontfix
firefox111 --- fixed

People

(Reporter: rpopovici, Assigned: steven100695)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Found in

  • Nightly 109.0a1

Affected versions

  • Nightly 109.0a1

Tested platforms

  • Affected platforms: All MacOS
  • Unaffected platforms: Win 10, Ubuntu

Preconditions

  • Opera/Vivaldi are installed and has user data to import:
    browsing history
    saved bookmarks
    saved Logins and Passwords
    search bar history
    cookies
  • Set prefs "browser.migrate.opera.enabled" and "browser.migrate.vivaldi.enabled" on true on Firefox.

Steps to reproduce

  1. Open Firefox
  2. Choose one of the options to Import Data from Another Browser(from first run migration, Library, Bookmarks Toolbar or about:logins).

Expected result

  • Cookies option should be removed from items list to import. No cookies are imported

Actual result

  • Cookies option is displayed on items list to import

Regression range

  • Not a regression. This is a new change of the new feature implementation.

Additional notes

  • This change is confirmed by Mike with the following enhancement: 1523681
Severity: -- → S4
Has STR: --- → yes
Assignee: nobody → steven100695

Removing cookie import no longer blocks enabling these new migrators by default.

No longer blocks: 1800928, 1800929, 1800934

Importing cookies from other browsers is something we want to stop supporting for the following reasons:

  1. We can accidentally import tracking cookies from browsers that don't have Firefox's tracking protection, which circumvents this protection
  2. Session cookies, these days, aren't often enough to get a proper session working after switching browsers. Most major websites notice when the user agent has changed despite having a cookie set, and will require you to sign-in again anyways, negating the value of the session cookie.

There might be some cookies that are worth migrating, but it's going to be different from site to site. After evaluating the options, we think it's safest to just not migrate cookies from other browsers.

We do, however, want to migrate cookies with the FirefoxProfileMigrator when doing something like a Firefox Profile Reset. So we don't want to get rid of the resource type altogether.

Summary: Remove cookies migration from Opera/Opera GX and Vivaldi → Remove cookies migration (except for FirefoxProfileMigrator)

stevenw,

What we want to do is basically get rid of all of the cookie migration resources for the other browsers.

That's this for Chrome-based browsers, and this for IE/Edge Legacy. We'll want to also remove anything that refers to those things, and anything that tests them.

Blocks: calstate
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4d4272f2637d Remove cookies migration (except for FirefoxProfileMigrator). r=mconley.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit auto_nag documentation.

This removal should ride the trains and not uplift.

Verified fixed on macOS 11, Ubuntu 18 and Win 10 using Nightly 111.0a1(build from 13.02.2023). Cookies are removed from Import Wizard but I have to mention that I observed some cookies from cnn.com(site bookmarked on Opera/OperaGX/Vivaldi and imported on Firefox) on Manage Data(hamburger menu->Settings-> Cookies->Manage data). Is this the intended behaviour?

Flags: needinfo?(mconley)

Ralu:

Was this in a fresh profile that didn't have those cookies set before importing? If so, can you supply the full STR (including the URL of the bookmark), and I'll take a look. Thanks!

Flags: needinfo?(mconley) → needinfo?(raluca.popovici)

Hello Mike,
Yes, with fresh profile.
Steps to reproduce:

  1. Open Firefox with a fresh profile
  2. Open Opera and bookmark few sites: https://edition.cnn.com/?refresh=1
  3. Go to Firefox -> Bookmarks from Menu bar-> Manage Bookmarks->Import Data from Another Browser-> Choose Opera
  4. Open Settings from Hamburger Menu and search for Manage Data(Cookies section)
    Actual result: Cookies from cnn are displayed. I attached a photo with cookies.
Flags: needinfo?(raluca.popovici) → needinfo?(mconley)
Attached image Screenshot 2023-02-27 at 10.57.45.png (deleted) —
Attached image What mconley sees after STR (deleted) —

Hi Ralu,

I'm not able to reproduce the experience. Are you certain that you're checking the Cookies list before any visits to cnn.com in the browser?

I've attached what I see in the Cookie management dialog after I run your STR in a fresh profile in Nightly.

Flags: needinfo?(mconley) → needinfo?(raluca.popovici)

Hi Mike,
Yes I checked the Cookies list before the import(no cnn.com cookies).

Flags: needinfo?(raluca.popovici)
Duplicate of this bug: 1523681
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: