Closed
Bug 1801161
Opened 2 years ago
Closed 2 years ago
Rename CancelAllOngoingPreloads::CancelAllOngoingPreloads to CancelAllOngoingPreloads::CancelAll
Categories
(Core :: Networking: HTTP, task, P3)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
112 Branch
| Tracking | Status | |
|---|---|---|
| firefox112 | --- | fixed |
People
(Reporter: manuel, Assigned: gotlou)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [necko-triaged])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Occurences: https://searchfox.org/mozilla-central/search?q=CancelAllOngoingPreloads
Raised in https://phabricator.services.mozilla.com/D149643?id=646349#inline-891623
The function name could be just CancellAll - Since it's already on a class called OngoingEarlyHints
|
Reporter | |
Updated•2 years ago
|
Whiteboard: [necko-triaged]
|
||
Updated•2 years ago
|
|
|
Reporter | |
Updated•2 years ago
|
Keywords: good-first-bug
|
|
Reporter | |
Updated•2 years ago
|
Summary: Followup on phase2 early hint preloader: rename CancelAllOngoingPreloads → Rename CancelAllOngoingPreloads to CancelAll to avoid name duplication
|
|
Reporter | |
Updated•2 years ago
|
Summary: Rename CancelAllOngoingPreloads to CancelAll to avoid name duplication → Rename CancelAllOngoingPreloads::CancelAllOngoingPreloads to CancelAllOngoingPreloads::CancelAll
|
Assignee | |
Comment 1•2 years ago
|
||
As described in the original bugreport, the name can be shortened since
the original name is kind of redundant. The necessary files were changed to
call the renamed function
|
||
Updated•2 years ago
|
Assignee: nobody → gotlouemail
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•2 years ago
|
||
Hello, I saw this bug report and as a first-time contributor to Firefox, have made the necessary changes as outlined from the information given in this bugreport
Pushed by mbucher@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0390c6488ad2
Rename CancelAllOngoingPreloads to CancelAll. r=manuel,necko-reviewers,valentin@mozilla.com
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox112:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•