Closed Bug 1801204 Opened 2 years ago Closed 2 years ago

Update recently-closed-tabs.mjs to be template-driven

Categories

(Firefox :: Firefox View, task, P3)

Product:
Firefox
Component:
Firefox View
Type:
task
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
firefox112 --- fixed

People

(Reporter: kcochrane, Assigned: kcochrane)

References

Details

(Whiteboard: [fidefe-2022-mr1-firefox-view] )

Attachments

(1 file)

Bug 1801204 - Update recently-closed-tabs.mjs to be template-driven r=sfoster,mstriemer
(deleted), text/x-phabricator-request
Details

While working on Bug 1787945, it was proposed that we use a template for the markup of each recently closed list item rather than generating elements from the script. This will prevent the need to regenerate elements that will not change in each list item such as the new dismiss button and its fluent string driven aria-label.

Type: enhancement → task
Priority: -- → P3
Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED

Unassigning myself from the bug because of my move to the Fx Client team.

Assignee: prathikshaprasadsuman → nobody
Status: ASSIGNED → NEW
Assignee: nobody → kcochrane

Adding a link to this try push where mstriemer suggested implementation of templating via Lint to synced tab cards in Tab Pickup for reference.

Status: NEW → ASSIGNED
Attachment #9316219 - Attachment description: WIP: Bug 1801204 - Update recently-closed-tabs.mjs to be template-driven r=sfoster,mstriemer → Bug 1801204 - Update recently-closed-tabs.mjs to be template-driven r=sfoster,mstriemer
Pushed by kcochrane@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2ca3d042a78d Update recently-closed-tabs.mjs to be template-driven r=sfoster,mstriemer

Backed out changeset 2ca3d042a78d (Bug 1801204) for causing multiple bc failures.
Backout link
Push with failures
Failure Log
Also dt7
Also bc1

Flags: needinfo?(kcochrane)
Flags: needinfo?(kcochrane)
Pushed by kcochrane@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e9f8085fe835 Update recently-closed-tabs.mjs to be template-driven r=sfoster,mstriemer

https://hg.mozilla.org/mozilla-central/rev/e9f8085fe835

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox112: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
Regressions: 1824358
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: