My understanding is that this was not possible before because on HCM etcetera we'd use the wrong colors. But now non-native menus use system colors, so I think we should be able to do this and remove a bunch of complexity from Windows' menu / popup styling.

My understanding is that this was not possible before because on HCM
etcetera we'd use the wrong colors.

But now non-native menus use system colors, so we can tweak the code
so that on HCM and non-default windows themes they do the right thing.

This should allow us to remove a bunch of complexity from Windows' menu
/ popup styling.

My understanding is that this was not possible before because on HCM
etcetera we'd use the wrong colors.

But now non-native menus use system colors, so we can tweak the code
so that on HCM and non-default windows themes they do the right thing.

This should allow us to remove a bunch of complexity from Windows' menu
/ popup styling.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #0)

My understanding is that this was not possible before because on HCM etcetera we'd use the wrong colors. But now non-native menus use system colors, so I think we should be able to do this and remove a bunch of complexity from Windows' menu / popup styling.

Well, on win7 there was also the "aero" styling for "glass"-y themes. What do we do for that with this patchset? (I haven't yet looked at code and I'm away from my Windows machine and VMs until roughly this time tomorrow so I can't test easily either, plus with my minimal availability I feel like maybe I've missed some steps in this process.)

The key here is that we use the native theme colors even for HCM / non-default themes. I can't test aero right now (because my VM setup doesn't support it), but I suspect we'd lose the glass effect indeed.

That's something we've already lost a while ago on scrollbars for example (see bug 1755605), so it doesn't seem super-concerning as long as the result is reasonable IMO. I'll make sure to test aero in any case and at least confirm that our behavior there is sensible.

Aero lite at least seems to use the same Win10 colors (-moz-windows-default-theme is true there). Will test real aero in a bit.

Same for actual aero.