Closed Bug 1802525 Opened 2 years ago Closed 2 years ago

Why does GiveUpBytecodeEncoding call FinishIncrementalEncoding?

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
109 Branch
Tracking Status
firefox109 --- fixed

People

(Reporter: nbp, Assigned: arai)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

FinishIncrementalEncoding was meant as a way to aggregate every pieces of bytecode generated during the start of web pages, to make it a viable output to be stored in a cache.

GiveUpBytecodeEncoding was meant to gracefully handle failures before being able to store any bytecode in the cache. At this stage our goal reclaim the memory.

FinishIncrementalEncoding does not seems to fit the scenario depicted by the context in which GiveUpBytecodeEncoding might be called.

https://searchfox.org/mozilla-central/rev/fadd0a14d2a2724ee4733ef73970a2ddd457a43f/dom/script/ScriptLoader.cpp#2628,2660

Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/777f345bd0c5 Do not perform serialization in GiveUpBytecodeEncoding. r=nbp
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: