Closed
Bug 1803166
Opened 2 years ago
Closed 2 years ago
mach esmify "found N files" suggests it found N files that match which is confusing/terrifying
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
109 Branch
| Tracking | Status | |
|---|---|---|
| firefox109 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Trying to use mach esmify I got:
0:01.79 [INFO] Searching files to rewrite imports...
0:02.20 [INFO] Found 3615 file(s). Rewriting imports...
when running just against browser/. This was surprising as I expected a few dozen, up to 100, given I got 118 hits (some files with multiple hits) on searchfox for files with the prefix I was migrating.
So I wonder if we could make this wording less scary.
|
||
Updated•2 years ago
|
Blocks: esm-ification
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
|
||
Comment 2•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•