Closed Bug 1803884 Opened 2 years ago Closed 2 years ago

Intermittent netwerk/test/browser/browser_103_assets.js | single tracking bug

Categories

(Core :: Networking, defect, P5)

defect

Tracking

()

RESOLVED FIXED
110 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox107 --- unaffected
firefox108 --- unaffected
firefox109 --- wontfix
firefox110 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: manuel)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: intermittent-failure, intermittent-testcase, regression)

Attachments

(1 file)

Filed by: nbeleuzu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=398536266&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/OaRKC6rwQVeWm3H3IfiU1g/runs/0/artifacts/public/logs/live_backing.log


[task 2022-12-03T10:16:47.654Z] 10:16:47     INFO - TEST-PASS | netwerk/test/browser/browser_103_assets.js | test_103_asset_normal (font): unexpected amount of normal request made expected 1 ({"hinted":0,"normal":1}), got 1 ({"hinted":0,"normal":1}) - true == true - 
[task 2022-12-03T10:16:47.663Z] 10:16:47     INFO - Console message: [JavaScript Error: "downloadable font: rejected by sanitizer (font-family: "preloadFont" style:normal weight:400 stretch:100 src index:0) source: https://example.com/browser/netwerk/test/browser/early_hint_asset.sjs?as=font&uuid={2f33649a-e69f-4a15-bc01-7288a197fb8e}"]
[task 2022-12-03T10:16:47.664Z] 10:16:47     INFO - Buffered messages finished
[task 2022-12-03T10:16:47.666Z] 10:16:47     INFO - TEST-UNEXPECTED-FAIL | netwerk/test/browser/browser_103_assets.js | test_103_asset_hinted (font): unexpected amount of hinted request made expected 1 ({"hinted":1,"normal":0}), got 0 ({"hinted":0,"normal":1}) - false == true - JS frame :: resource://testing-common/early_hint_preload_test_helper.jsm :: request_count_checking :: line 27
[task 2022-12-03T10:16:47.667Z] 10:16:47     INFO - Stack trace:
[task 2022-12-03T10:16:47.668Z] 10:16:47     INFO - resource://testing-common/early_hint_preload_test_helper.jsm:request_count_checking:27
[task 2022-12-03T10:16:47.669Z] 10:16:47     INFO - chrome://mochitests/content/browser/netwerk/test/browser/browser_103_assets.js:test_hint_asset:41
[task 2022-12-03T10:16:47.670Z] 10:16:47     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-12-03T10:16:47.672Z] 10:16:47     INFO - TEST-UNEXPECTED-FAIL | netwerk/test/browser/browser_103_assets.js | test_103_asset_hinted (font): unexpected amount of normal request made expected 0 ({"hinted":1,"normal":0}), got 1 ({"hinted":0,"normal":1}) - false == true - JS frame :: resource://testing-common/early_hint_preload_test_helper.jsm :: request_count_checking :: line 34
[task 2022-12-03T10:16:47.673Z] 10:16:47     INFO - Stack trace:
[task 2022-12-03T10:16:47.674Z] 10:16:47     INFO - resource://testing-common/early_hint_preload_test_helper.jsm:request_count_checking:34
[task 2022-12-03T10:16:47.675Z] 10:16:47     INFO - chrome://mochitests/content/browser/netwerk/test/browser/browser_103_assets.js:test_hint_asset:41
[task 2022-12-03T10:16:47.676Z] 10:16:47     INFO - Leaving test bound test_103_asset_font
[task 2022-12-03T10:16:47.677Z] 10:16:47     INFO - Entering test bound test_103_asset_fetch

:manuel, since you are the author of the regressor, bug 1771867, could you take a look?

For more information, please visit auto_nag documentation.

Flags: needinfo?(manuel)
Blocks: earlyhints
Flags: needinfo?(manuel)

Set release status flags based on info from the regressing bug 1771867

The data race is happening, because nsHttpTransaction::ParseLineSegment
can be called before nsHttpTransaction::AsyncRead. Initializing it in
nsHttpTransaction::Init removes the race condition.

Should fix most early hint intermittent:

Assignee: nobody → manuel
Status: NEW → ASSIGNED

Set release status flags based on info from the regressing bug 1771867

Pushed by mbucher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/40b60e5f1d72 Early Hints: Fix race condition of setting mEarlyHintObserver and dispatching Early Hints in nsHttpTransaction::ParseLineSegment r=necko-reviewers,kershaw
Flags: needinfo?(manuel)
Pushed by mbucher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b816f9b676bb Early Hints: Fix race condition of setting mEarlyHintObserver and dispatching Early Hints in nsHttpTransaction::ParseLineSegment r=necko-reviewers,kershaw
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch

The patch landed in nightly and beta is affected.
:manuel, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox109 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(manuel)
Flags: needinfo?(kershaw)

This only affects testing, so no need to uplift.

Flags: needinfo?(kershaw)
Flags: needinfo?(manuel)
Duplicate of this bug: 1744028
Duplicate of this bug: 1775763
Duplicate of this bug: 1746324
Duplicate of this bug: 1760124
Duplicate of this bug: 1804494
Duplicate of this bug: 1805067
Duplicate of this bug: 1804846
Duplicate of this bug: 1806982
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: