Closed
Bug 1804525
Opened 2 years ago
Closed 2 years ago
Make weather suggestions blockable
Categories
(Firefox :: Address Bar, task, P2)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
109 Branch
Tracking | Status | |
---|---|---|
firefox109 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Weather suggestions need to be blockable/dismissable.
Assignee | ||
Comment 1•2 years ago
|
||
This makes the weather suggestion blockable. It depends on the new isBlockable
payload property added in D163766. The suggestion's row in the view will
automatically get a block button by setting that property.
We don't have an existing browser-chrome test for the block button by itself to
make sure picking it removes the row, so I added a task to
browser_remove_match.js.
The change to test_weather.js makes sure calling blockResult()
on the provider
correctly disables the suggest.weather
pref.
Depends on D163766
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc54fa985606
Make weather suggestions blockable. r=daisuke
Comment 3•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox109:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•