Closed
Bug 1805100
Opened 2 years ago
Closed 2 years ago
chrome/nsChromeRegistryContent.cpp: do not use 'else' after 'return'
Categories
(Core :: General, task)
Core
General
Tracking
()
RESOLVED
FIXED
110 Branch
| Tracking | Status | |
|---|---|---|
| firefox110 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: diegomoreno.pro45)
References
(Blocks 1 open bug)
Details
(Whiteboard: [lang=C++][no-nag])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details |
Filling as a good first bug to learn workflows.
do not use 'else' after 'return':
https://searchfox.org/mozilla-central/rev/14cb5e441592eca78b22ac0bdb5dfd1808ef4324/chrome/nsChromeRegistryContent.cpp#113-124
https://searchfox.org/mozilla-central/rev/14cb5e441592eca78b22ac0bdb5dfd1808ef4324/chrome/nsChromeRegistryChrome.cpp#328-337
pretty much the same code in two files
They can be a bit simplified
Found by https://clang.llvm.org/extra/clang-tidy/checks/readability/else-after-return.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
|
||
Comment 1•2 years ago
|
||
The bug assignee is inactive on Bugzilla, so the assignee is being reset.
Assignee: diegomoreno.pro45 → nobody
|
Reporter | |
Updated•2 years ago
|
Assignee: nobody → diegomoreno.pro45
Whiteboard: [lang=C++] → [lang=C++][no-nag]
|
Assignee | |
Comment 2•2 years ago
|
||
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
||
Updated•2 years ago
|
Attachment #9307837 -
Attachment description: Bug 1805100 - Remove "else if" after interruptions of control flow and patch Lint warns. r=sylvestre → Bug 1805100 - Remove "else if" after interruptions of control flow. r=sylvestre
|
|
||
Updated•2 years ago
|
Attachment #9307807 -
Attachment is obsolete: true
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c99675e1ba8f
Remove "else if" after interruptions of control flow. r=sylvestre
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox110:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•