Closed
Bug 1805147
Opened 2 years ago
Closed 2 years ago
Potential deadlock in nsAvailableMemoryWatcher::Observe
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
110 Branch
| Tracking | Status | |
|---|---|---|
| firefox110 | --- | fixed |
People
(Reporter: jstutte, Assigned: jstutte)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
From https://treeherder.mozilla.org/logviewer?job_id=398938924&repo=autoland&lineNumber=8890 it seems that we:
- lock
mMutexon the main thread before calling shutdown which then wants to shutdown the MemoryPoller thread - try to lock the same
mMutexinsidensAvailableMemoryWatcher::MaybeHandleHighMemoryon the MemoryPoller thread while processing the last events there, causing a deadlock
I wonder why the shutdown method needs to lock that mutex at all?
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → jstutte
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•2 years ago
|
||
From code reading it seems that Windows and MacOS are not affected by this.
OS: Unspecified → Linux
Pushed by jstutte@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/912e096ae1de
Do not hold a lock on mMutex while waiting for the thread to shut down. r=gsvelto
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox110:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•