Firefox view "Learn how" link for SUMO page doesn't work
Categories
(Firefox :: Firefox View, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr102 | --- | unaffected |
firefox108 | --- | unaffected |
firefox109 | + | verified |
firefox110 | + | verified |
People
(Reporter: Gabi, Assigned: sfoster)
References
(Blocks 2 open bugs, Regression)
Details
(Keywords: regression, Whiteboard: [fidefe-fxview-polish])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
Found in
- Firefox 109.0b1
Affected versions
- Firefox 109.0b1
- Firefox Nightly 110.0a1
Tested platforms
- Affected platforms: Windows 10x64, macOS 10.12, Ubuntu 18.4
- Unaffected platforms: none
Steps to reproduce
- Open Firefox view tab and continue to sign in with a Firefox account
- Log into Sync with valid credentials on another device and go through with the firefox view onboarding process for Tab Pickup
- Perform the onboarding process, click on the "Learn how" link when progress is at 33% and 66%
Expected result
- The "Learn how" link correctly redirects the user to the SUMO page.
Actual result
- Firefox view "Learn how" link for SUMO page doesn't work
Regression range
- First bad: 2022-12-07
- Last good: 2022-12-06
- Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8e09abeeb445553bd956d537bcf54fcdf812bb52&tochange=8d20cccc1dc681d05d412be763ee5a0602a47a4a
- Potentially regressed by: Bug 1803505 - Simplify the tab-pickup-container initialization. r=sclements
Comment 1•2 years ago
|
||
:sfoster, since you are the author of the regressor, bug 1803505, could you take a look?
For more information, please visit auto_nag documentation.
Comment 2•2 years ago
|
||
Set release status flags based on info from the regressing bug 1803505
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
Hrm, no tests caught this. Should probably fix that too - at least asserting that those links have a .href
.
Assignee | ||
Comment 4•2 years ago
|
||
Comment 6•2 years ago
|
||
bugherder |
Comment 7•2 years ago
|
||
Comment on attachment 9308752 [details]
Bug 1805391 - Ensure support links get their hrefs populated. r?sclements!
Beta/Release Uplift Approval Request
- User impact if declined: 109 will ship with broken "learn how" links in Firefox View setup steps.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: 1) Log in to your fx account in fx view, but only have one device connected (desktop). 2) In the Tab Pickup section, where you see the "Sync Firefox on your phone or tablet" setup flow step, click on the "Learn how" link which should now open the SUMO page.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Only affects the Firefox View UI
- String changes made/needed: None
- Is Android affected?: No
Updated•2 years ago
|
Comment 8•2 years ago
|
||
Comment on attachment 9308752 [details]
Bug 1805391 - Ensure support links get their hrefs populated. r?sclements!
Approved for 109.0b5. Thanks for including a test.
Comment 9•2 years ago
|
||
bugherder uplift |
Updated•2 years ago
|
Reporter | ||
Comment 10•2 years ago
|
||
Verified as fixed with Firefox Nightly 110.0a1 on Windows 10x64, Ubuntu 20 and macOS 10.13.6.
Reporter | ||
Updated•2 years ago
|
Reporter | ||
Comment 11•2 years ago
|
||
Verified as fixed with Firefox 109.0b5 on Windows 10x64, Ubuntu 18.4 and macOS 10.13.6.
Reporter | ||
Updated•2 years ago
|
Reporter | ||
Updated•2 years ago
|
Description
•