We lost a little bit of test coverage in bug 1804807 because I removed tasks where improve_suggest_experience_checked was expected to be true but didn't include any equivalent checks in the refactor.

This adds checks to the main sponsored and nonsponsored tests to ensure we have
test cases where this value is both true and false. I think it's important to
have test cases for both sponsored and nonsponsored suggestions since these are
the two main types of Firefox Suggest suggestions. I don't think it's necessary
for other types of suggestions because they all use the same logic, so if these
checks pass for sponsored and nonsponsored suggestions, we can be reasonably
sure other suggestion types are handled correctly.

https://hg.mozilla.org/mozilla-central/rev/0454b77be03f

Comment on attachment 9308150 [details]
Bug 1805576 - Add back telemetry tests for improve_suggest_experience_checked = true.

Beta/Release Uplift Approval Request

• User impact if declined: This patch only modifies two test files so there's no direct user impact. We lost some test coverage at the end of the 109 cycle and this patch adds it back. It would be good to have this test coverage on 109 but it's not required.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a test-only patch.
• String changes made/needed:
• Is Android affected?: No

Comment on attachment 9308150 [details]
Bug 1805576 - Add back telemetry tests for improve_suggest_experience_checked = true.

Approved for 109.0b4.

https://hg.mozilla.org/releases/mozilla-beta/rev/b6f9715b7a2a