Closed Bug 1806412 Opened 2 years ago Closed 2 years ago

Implement TRR fallback warning page

Categories

(Core :: Networking: DNS, task, P2)

Product:
Core
Component:
Networking: DNS
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox111 --- fixed

People

(Reporter: valentin, Assigned: acreskey)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [necko-triaged])

Attachments

(5 files, 2 obsolete files)

Bug 1806412 - Add new skip reasons to nsITRRSkipReasons.idl for each of the heuristicsi r=#necko-reviewers
(deleted), text/x-phabricator-request
Details
Bug 1806412 - Expose the DNS heuristics to the DNS service api r=#necko-reviewers
(deleted), text/x-phabricator-request
Details
Bug 1806412 - Record DoH heuristic failure and fallback logic r=#necko-reviewers
(deleted), text/x-phabricator-request
Details
Bug 1806412 - Add a custom about:neterror page for the DNS native fallback warning r=#necko-reviewers
(deleted), text/x-phabricator-request
Details
Bug 1806412 - Pass trr mode to content process r=#necko-reviewers
(deleted), text/x-phabricator-request
Details

We want to show the user a warning page before we start falling back to native DNS.

To do this, we can extend the page added in bug 1596845.

  1. Add new skip reasons to nsITRRSkipReasons.idl for each of the heuristics.
  2. Add a new method on nsIDNSService - like setHeuristicDetection(Ci.nsITRRSkipReason. [tripped heuristic])
  3. then after running heuristics we need to call the method with the id of the trippd heuristic, or Ci.nsITRRSkipReason.TRR_OK if none were tripped.
  4. in nsHostResolver::NameLookup we need to check the value of setHeuristicDetection - and if it's a tripped heuristic, call rec->RecordReason(TRRSkippedReason::[reason]);
  5. We need two prefs - the first is whether to show the fallback warning page at all. The second is whether the user has chosen to always continue.
  6. Depending on the value of the prefs, we might not call NativeLookup , so we should just return NS_ERROR_UNKNOWN_HOST to the caller, leading to the warning page showing up.
  7. We might need another array of domains that we append to TRRService::mExcludedDomains every time we reset them.

The Bugbug bot thinks this bug should belong to the 'Core::Networking: DNS' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: General → Networking: DNS
Product: Firefox → Core
Severity: -- → N/A
Type: enhancement → task
Priority: -- → P2
Whiteboard: [necko-triaged]

wip Adds new skip reasons for heuristics tripped and records them
Prevents fallback to native if new fallback warning pref is enabled and not disabled.

We will need these exposed to differentiate failure reasons.

Depends on D165558

Attachment #9309330 - Attachment is obsolete: true
Attachment #9309191 - Attachment is obsolete: true
Attachment #9309902 - Attachment description: WIP: Bug 1806412 - Record DoH heuristic failure and fallback logic → Bug 1806412 - Record DoH heuristic failure and fallback logic
Attachment #9309909 - Attachment description: WIP: Bug 1806412 - Pass trr mode to content process → Bug 1806412 - Pass trr mode to content process
Attachment #9309902 - Attachment description: Bug 1806412 - Record DoH heuristic failure and fallback logic → WIP: Bug 1806412 - Record DoH heuristic failure and fallback logic
Attachment #9309909 - Attachment description: Bug 1806412 - Pass trr mode to content process → WIP: Bug 1806412 - Pass trr mode to content process
Attachment #9309901 - Attachment description: WIP: Bug 1806412 - Expose the DNS heuristics to the DNS service → Bug 1806412 - Expose the DNS heuristics to the DNS service
Attachment #9309902 - Attachment description: WIP: Bug 1806412 - Record DoH heuristic failure and fallback logic → Bug 1806412 - Record DoH heuristic failure and fallback logic r=necko-reviewers
Attachment #9309903 - Attachment description: WIP: Bug 1806412 - Add a custom about:neterror page for the DNS native fallback warning → WIP: Bug 1806412 - Add a custom about:neterror page for the DNS native fallback warning r=necko-reviewers
Attachment #9309909 - Attachment description: WIP: Bug 1806412 - Pass trr mode to content process → Bug 1806412 - Pass trr mode to content process r=necko-reviewers
Attachment #9309901 - Attachment description: Bug 1806412 - Expose the DNS heuristics to the DNS service → WIP: Bug 1806412 - Expose the DNS heuristics to the DNS service
Attachment #9309902 - Attachment description: Bug 1806412 - Record DoH heuristic failure and fallback logic r=necko-reviewers → WIP: Bug 1806412 - Record DoH heuristic failure and fallback logic
Attachment #9309903 - Attachment description: WIP: Bug 1806412 - Add a custom about:neterror page for the DNS native fallback warning r=necko-reviewers → WIP: Bug 1806412 - Add a custom about:neterror page for the DNS native fallback warning
Attachment #9309909 - Attachment description: Bug 1806412 - Pass trr mode to content process r=necko-reviewers → WIP: Bug 1806412 - Pass trr mode to content process
Attachment #9309909 - Attachment description: WIP: Bug 1806412 - Pass trr mode to content process → Bug 1806412 - Pass trr mode to content process r=#necko-reviewers
Attachment #9309899 - Attachment description: WIP: Bug 1806412 - Add new skip reasons to nsITRRSkipReasons.idl for each of the heuristics → Bug 1806412 - Add new skip reasons to nsITRRSkipReasons.idl for each of the heuristicsi r=#necko-reviewers
Attachment #9309901 - Attachment description: WIP: Bug 1806412 - Expose the DNS heuristics to the DNS service → Bug 1806412 - Expose the DNS heuristics to the DNS service api r=#necko-reviewers
Attachment #9309902 - Attachment description: WIP: Bug 1806412 - Record DoH heuristic failure and fallback logic → Bug 1806412 - Record DoH heuristic failure and fallback logic r=#necko-reviewers
Attachment #9309903 - Attachment description: WIP: Bug 1806412 - Add a custom about:neterror page for the DNS native fallback warning → Bug 1806412 - Add a custom about:neterror page for the DNS native fallback warning r=#necko-reviewers
Blocks: 1810005
Pushed by acreskey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a12595f10b1a Add new skip reasons to nsITRRSkipReasons.idl for each of the heuristicsi r=necko-reviewers,valentin https://hg.mozilla.org/integration/autoland/rev/9659a47871f3 Expose the DNS heuristics to the DNS service api r=necko-reviewers,valentin https://hg.mozilla.org/integration/autoland/rev/1a177fd28da2 Record DoH heuristic failure and fallback logic r=necko-reviewers,valentin https://hg.mozilla.org/integration/autoland/rev/425fc5b63cff Add a custom about:neterror page for the DNS native fallback warning r=necko-reviewers,fluent-reviewers,flod,valentin,pbz https://hg.mozilla.org/integration/autoland/rev/c5061e420b1a Pass trr mode to content process r=necko-reviewers,valentin
Depends on: 1814891
Blocks: 1829342
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: