Closed Bug 1806618 Opened 2 years ago Closed 2 years ago

RUST_PROGRAMS are always rebuilt upon ./mach build

Categories

(Firefox Build System :: General, task)

Product:
Firefox Build System
Component:
General
Type:
task

Tracking

(firefox113 fixed)

Status:
RESOLVED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
firefox113 --- fixed

People

(Reporter: sergesanspaille, Assigned: sergesanspaille)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1806618 - Avoid rebuilding RUST_PROGRAMS based on dependencies
(deleted), text/x-phabricator-request
Details

After a ./mach build run, launching a new run systematically rebuilds all $(RUST_PROGRAMS) systematically, that should be avoided.

Blocks: 1806617

cargo generates dependency file for each program, systematically. Use it
to avoid redundant builds.

This handles the following situations:

  • Cargo file is updated
  • One of the dependency output by cargo is updated
  • Binary is manually removed
  • Dependency file is manually removed
Attachment #9309172 - Attachment description: Bug 1806618 - Avoid rebuilding RUST_PROGRAMS based on dependencies → WIP: Bug 1806618 - Avoid rebuilding RUST_PROGRAMS based on dependencies
Attachment #9309172 - Attachment description: WIP: Bug 1806618 - Avoid rebuilding RUST_PROGRAMS based on dependencies → Bug 1806618 - Avoid rebuilding RUST_PROGRAMS based on dependencies
Type: enhancement → task
Pushed by sguelton@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e00332f32a2d Avoid rebuilding RUST_PROGRAMS based on dependencies r=sylvestre,ahochheiden,firefox-build-system-reviewers
Backout by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8d82468b791b Backed out 2 changesets (bug 1806618, bug 1808184) for causing build bustages.
Pushed by sguelton@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6445ca9d0ee4 Avoid rebuilding RUST_PROGRAMS based on dependencies r=sylvestre,ahochheiden,firefox-build-system-reviewers

Backed out 2 changesets (Bug 1806618, Bug 1808184) for causing build bustages.
Backout link
Push with failures <--> p
Failure Log
Also Bp Failure Log

Flags: needinfo?(sguelton)
Pushed by sguelton@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7ec1bb4654ac Avoid rebuilding RUST_PROGRAMS based on dependencies r=sylvestre,ahochheiden,firefox-build-system-reviewers

https://hg.mozilla.org/mozilla-central/rev/7ec1bb4654ac

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox113: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Flags: needinfo?(sguelton)
Regressions: 1825555
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: