Closed Bug 1806788 Opened 2 years ago Closed 1 years ago

Update the Element Origin concept for WebDriver BiDi

Categories

(Remote Protocol :: Marionette, task, P2)

Product:
Remote Protocol
Component:
Marionette
Version:
Default
Type:
task
Points:
2

Tracking

(firefox114 fixed)

Status:
RESOLVED FIXED
Milestone:
114 Branch
Tracking Flags:
Tracking Status
firefox114 --- fixed

People

(Reporter: whimboo, Assigned: jdescottes)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [webdriver:m7][wptsync upstream])

Attachments

(4 files, 3 obsolete files)

Bug 1806788 - [remote] Support actions using an element origin
(deleted), text/x-phabricator-request
Details
Bug 1806788 - [wdspec] Fix wrong helper name in bidi pointer_touch.py test
(deleted), text/x-phabricator-request
Details
Bug 1806788 - [wdspec] Fix element origin arguments used for bidi performActions tests
(deleted), text/x-phabricator-request
Details
Bug 1806788 - [wdspec] Add more tests for invalid origin arguments for bidi perform actions
(deleted), text/x-phabricator-request
Details

The required work for this bug is based on: https://github.com/w3c/webdriver/pull/1653

The current actions code in Marionette needs to be updated to reflect the new concept as to be landed via the above pull request.

Blocks: 1792089

When working on this implementation we should make sure to add tests for inappropriately specifying a Shadow Root as origin to any possible Perform Actions combination. Currently we seem to fail with invalid argument (400): data did not match any variant of untagged enum PointerActionItem at line 1 column 270 because of geckodriver.

Assignee: nobody → hskupin
Status: NEW → ASSIGNED

While trying to get this implemented I noticed that we may need slight modifications of the current actions code. But to verify I would need a way to actually work with Elements in WebDriver BiDi. As such we would need bug 1770733 first.

Assignee: hskupin → nobody
Status: ASSIGNED → NEW
Depends on: 1770733
Product: Testing → Remote Protocol
Blocks: 1792090
No longer blocks: 1792090
Depends on: 1792090
Whiteboard: [webdriver:m6] → [webdriver:m7]
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Assignee: jdescottes → nobody
Status: ASSIGNED → NEW
Priority: P1 → P2

It would be good to have all the test cases as BiDi tests. Given that this work is currently done via bug 1806801 lets wait for it.

Depends on: 1806801
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Attachment #9331445 - Attachment description: Bug 1806788 - [remote] Handle actions with serialized origins using sharedId → Bug 1806788 - [remote] Support actions using an element origin
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/665d53d598de [wdspec] Fix element origin arguments used for bidi performActions tests r=webdriver-reviewers,jgraham https://hg.mozilla.org/integration/autoland/rev/fa7dde91f5f9 [wdspec] Fix wrong helper name in bidi pointer_touch.py test r=webdriver-reviewers,jgraham https://hg.mozilla.org/integration/autoland/rev/f085281244af [remote] Support actions using an element origin r=webdriver-reviewers,jgraham https://hg.mozilla.org/integration/autoland/rev/2aa5598e5e9b [wdspec] Add more tests for invalid origin arguments for bidi perform actions r=webdriver-reviewers,jgraham
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39867 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m7] → [webdriver:m7], [wptsync upstream]
Blocks: 1832028
Blocks: 1832031
Upstream PR merged by moz-wptsync-bot
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8395c43e8ab3 [wpt PR 39867] - [Gecko Bug 1806788] [wdspec] Fix element origin arguments used for bidi performActions tests, a=testonly
Whiteboard: [webdriver:m7], [wptsync upstream] → [webdriver:m7][wptsync upstream][webdriver:relnote]

Actually this is not a visible change for Marionette and for BiDi we had input.performActions as experimental API. As such we don't need this bug in the release notes.

Whiteboard: [webdriver:m7][wptsync upstream][webdriver:relnote] → [webdriver:m7][wptsync upstream]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: