Closed Bug 1807965 Opened 2 years ago Closed 2 years ago

Crash [@ get]

Categories

(Core :: Layout, defect)

x86_64
Linux
defect

Tracking

()

RESOLVED DUPLICATE of bug 1807769
Tracking Status
firefox-esr102 --- unaffected
firefox108 --- unaffected
firefox109 --- affected
firefox110 --- affected

People

(Reporter: jkratzer, Unassigned)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression, testcase, Whiteboard: [bugmon:bisected,confirmed])

Crash Data

Attachments

(1 file)

Testcase found while fuzzing mozilla-central rev c5ddc463e9f8 (built with: --enable-address-sanitizer --enable-fuzzing).

Testcase can be reproduced using the following commands:

$ pip install fuzzfetch grizzly-framework
$ python -m fuzzfetch --build c5ddc463e9f8 --asan --fuzzing -n firefox
$ python -m grizzly.replay ./firefox/firefox testcase.html
[@ get]

    =================================================================
    ==131420==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000010 (pc 0x7fb29090f5ba bp 0x7ffd21ce9480 sp 0x7ffd21ce9480 T0)
    ==131420==The signal is caused by a READ memory access.
    ==131420==Hint: address points to the zero page.
        #0 0x7fb29090f5ba in get /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h:286:27
        #1 0x7fb29090f5ba in operator mozilla::dom::Selection * /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h:299:12
        #2 0x7fb29090f5ba in nsFrameSelection::GetSelection(mozilla::SelectionType) const /layout/generic/nsFrameSelection.cpp:1564:10
        #3 0x7fb2909f1518 in nsIFrame::HasSelectionInSubtree() /layout/generic/nsIFrame.cpp:6975:23
        #4 0x7fb2909f1817 in nsIFrame::UpdateIsRelevantContent(mozilla::EnumSet<mozilla::ContentRelevancyReason, unsigned char> const&) /layout/generic/nsIFrame.cpp:7049:23
        #5 0x7fb29069f934 in mozilla::PresShell::UpdateRelevancyOfContentVisibilityAutoFrames() /layout/base/PresShell.cpp:11939:12
        #6 0x7fb29069d7e1 in mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush) /layout/base/PresShell.cpp:4292:5
        #7 0x7fb28a8da92b in mozilla::dom::Document::FlushPendingNotifications(mozilla::ChangesToFlush) /dom/base/Document.cpp:10770:16
        #8 0x7fb2893b02f1 in nsDocLoader::DocLoaderIsEmpty(bool, mozilla::Maybe<nsresult> const&) /uriloader/base/nsDocLoader.cpp:742:14
        #9 0x7fb2893b2fa9 in nsDocLoader::OnStopRequest(nsIRequest*, nsresult) /uriloader/base/nsDocLoader.cpp:680:5
        #10 0x7fb2940cedba in nsDocShell::OnStopRequest(nsIRequest*, nsresult) /docshell/base/nsDocShell.cpp:13864:23
        #11 0x7fb287a7d642 in mozilla::net::nsLoadGroup::NotifyRemovalObservers(nsIRequest*, nsresult) /netwerk/base/nsLoadGroup.cpp:628:22
        #12 0x7fb287a7ffd4 in mozilla::net::nsLoadGroup::RemoveRequest(nsIRequest*, nsISupports*, nsresult) /netwerk/base/nsLoadGroup.cpp:532:10
        #13 0x7fb28a8e2481 in mozilla::dom::Document::DoUnblockOnload() /dom/base/Document.cpp:11551:18
        #14 0x7fb28a89274e in mozilla::dom::Document::UnblockOnload(bool) /dom/base/Document.cpp:11489:9
        #15 0x7fb28a8bb004 in mozilla::dom::Document::DispatchContentLoadedEvents() /dom/base/Document.cpp:8016:3
        #16 0x7fb28a9ab9fa in applyImpl<mozilla::dom::Document, void (mozilla::dom::Document::*)()> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1162:12
        #17 0x7fb28a9ab9fa in apply<mozilla::dom::Document, void (mozilla::dom::Document::*)()> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1168:12
        #18 0x7fb28a9ab9fa in mozilla::detail::RunnableMethodImpl<mozilla::dom::Document*, void (mozilla::dom::Document::*)(), true, (mozilla::RunnableKind)0>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1215:13
        #19 0x7fb2876bf34f in mozilla::SchedulerGroup::Runnable::Run() /xpcom/threads/SchedulerGroup.cpp:140:20
        #20 0x7fb2876d2ad9 in mozilla::RunnableTask::Run() /xpcom/threads/TaskController.cpp:539:16
        #21 0x7fb2876c98f7 in mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /xpcom/threads/TaskController.cpp:852:26
        #22 0x7fb2876c6b78 in mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /xpcom/threads/TaskController.cpp:684:15
        #23 0x7fb2876c72a0 in mozilla::TaskController::ProcessPendingMTTask(bool) /xpcom/threads/TaskController.cpp:462:36
        #24 0x7fb2876d8be1 in operator() /xpcom/threads/TaskController.cpp:188:37
        #25 0x7fb2876d8be1 in mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_2>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:546:5
        #26 0x7fb2876fbd44 in nsThread::ProcessNextEvent(bool, bool*) /xpcom/threads/nsThread.cpp:1197:16
        #27 0x7fb287706134 in NS_ProcessNextEvent(nsIThread*, bool) /xpcom/threads/nsThreadUtils.cpp:476:10
        #28 0x7fb288e696ae in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:85:21
        #29 0x7fb288cec507 in RunInternal /ipc/chromium/src/base/message_loop.cc:381:10
        #30 0x7fb288cec507 in RunHandler /ipc/chromium/src/base/message_loop.cc:374:3
        #31 0x7fb288cec507 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:356:3
        #32 0x7fb290032ec9 in nsBaseAppShell::Run() /widget/nsBaseAppShell.cpp:148:27
        #33 0x7fb294fab608 in XRE_RunAppShell() /toolkit/xre/nsEmbedFunctions.cpp:743:20
        #34 0x7fb288cec507 in RunInternal /ipc/chromium/src/base/message_loop.cc:381:10
        #35 0x7fb288cec507 in RunHandler /ipc/chromium/src/base/message_loop.cc:374:3
        #36 0x7fb288cec507 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:356:3
        #37 0x7fb294faad9f in XRE_InitChildProcess(int, char**, XREChildData const*) /toolkit/xre/nsEmbedFunctions.cpp:676:34
        #38 0x5580c7525454 in content_process_main(mozilla::Bootstrap*, int, char**) /browser/app/../../ipc/contentproc/plugin-container.cpp:57:28
        #39 0x5580c7525917 in main /browser/app/nsBrowserApp.cpp:359:18
        #40 0x7fb2a9d01d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
        #41 0x7fb2a9d01e3f in __libc_start_main csu/../csu/libc-start.c:392:3
        #42 0x5580c7463ed8 in _start (/home/jkratzer/builds/m-c-20221229092636-fuzzing-asan-opt/firefox+0x111ed8) (BuildId: 7041d944462f6ab2c4618c24c708ba0814efd194)
    
    AddressSanitizer can not provide additional info.
    SUMMARY: AddressSanitizer: SEGV /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h:286:27 in get
    ==131420==ABORTING
Attached file Testcase (deleted) —

Verified bug as reproducible on mozilla-central 20221229092636-c5ddc463e9f8.
The bug appears to have been introduced in the following build range:

Start: 71eb757374eb3bf875ad164016051ee8a4463644 (20221130221357)
End: 47c3acb30de24f5e38cab7daa67e9bb0cd56cafc (20221130233108)
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=71eb757374eb3bf875ad164016051ee8a4463644&tochange=47c3acb30de24f5e38cab7daa67e9bb0cd56cafc

Keywords: regression
Whiteboard: [bugmon:confirm] → [bugmon:bisected,confirmed]

Looks like a content-visibility:auto crash, based on that markup in the testcase. Likely regression from bug 1791759.

I confirmed that I can reproduce the crash, with layout.css.content-visibility.enabled toggled to true. My crash report was bp-e0a8c382-d6c2-42dd-b6cb-93e7a0221230 with signature [@ nsFrameSelection::GetSelection ] (adding to crash signature field here).

mrobinson, do you have cycles to take a look?

Severity: -- → S3
Crash Signature: [@ get] → [@ get] [@ nsFrameSelection::GetSelection ]
Flags: needinfo?(mrobinson)
Regressed by: 1791759

Set release status flags based on info from the regressing bug 1791759

I believe this is a duplicate of bug 1807769.

Status: NEW → RESOLVED
Closed: 2 years ago
Duplicate of bug: 1807769
Flags: needinfo?(mrobinson)
Resolution: --- → DUPLICATE

No valid actions for resolution (DUPLICATE).
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Keywords: bugmon
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: