Closed
Bug 1808172
Opened 2 years ago
Closed 2 years ago
Simplify handling of utility objects in Prompter.jsm
Categories
(Toolkit Graveyard :: Notifications and Alerts, task)
Toolkit Graveyard
Notifications and Alerts
Tracking
(firefox110 fixed)
RESOLVED
FIXED
110 Branch
| Tracking | Status | |
|---|---|---|
| firefox110 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Currently, Prompter.jsm imports PromptUtils from SharedPromptUtils.jsm, and then does a strange dance where it creates a temporarily object which inherits from PromptUtils. Finally it overwrites the imported PromptUtils with the new version.
There's a couple of options here. The first is to move all the additional functions into SharedPromptUtils.jsm, but I am not sure that is best - there are some fairly specific functions in there.
The other option is to separate the two objects - use Utils in Prompter.jsm which will not be extended from PromptUtils. They can then both be accessed directly when required, and it will be clear which object is in use.
|
Assignee | |
Comment 1•2 years ago
|
||
Depends on D165764
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/83e148b22444 Simplify handling of utility objects in Prompter.jsm. r=Gijs
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox110:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
|
||
Updated•1 year ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•