[wpt-sync] Sync PR 37739 - [Cookies] Update WPTs to set cookies with CTRL chars via HTTP
Categories
(Core :: Networking: Cookies, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox111 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Attachments
(1 file)
(deleted),
text/plain
|
Details |
Sync web-platform-tests PR 37739 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/37739
Details from upstream follow.
Andrew Williams <awillia@chromium.org> wrote:
[Cookies] Update WPTs to set cookies with CTRL chars via HTTP
Updates some existing WPTs that test handling of control characters
so that they set cookies via HTTP headers in addition to setting
cookies via document.cookie. This is useful since the handling
of control characters differs slightly between the two in Chrome.Note that I only updated the tests that add control characters
into the cookie name and values. I tried adding HTTP equivalents
to the tests in cookies/attributes/attributes-ctl.sub.html, but
with the combinations of attributes tested the time needed to
complete that test increased from a few seconds to over 2 minutes,
and the results were not different than what was shown by the
name and value tests (for Chrome at least).This CL also:
- Updates httpCookieTest so that the HTTP Fetch failing can be
treated as expected. This is useful because Chrome fails to
load any HTTP request containing a NULL character, which is
one of the special characters we test for.- Replaces the TestExpectation file entries with '-expected' files
- Simplifies cookies/attributes/attributes-ctl.sub.html
Bug: 1233602
Change-Id: I4a5be65c5cbe5ee97b47e67d49d6e87509ac4c74
Reviewed-on: https://chromium-review.googlesource.com/4128839
WPT-Export-Revision: 59aeaf30866d242ffc5c8387a2a366a4d3f0d7a2
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
Comment 4•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2aa61e4d3dcc
https://hg.mozilla.org/mozilla-central/rev/f4939d0d64a9
Description
•