[wpt-sync] Sync PR 37780 - Refactor and remove buffer option
Categories
(Core :: DOM: Performance, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox111 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
(Depends on 1 open bug, )
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 37780 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/37780
Details from upstream follow.
Hao Liu <haoliuk@chromium.org> wrote:
Refactor and remove buffer option
The test was flaky for 2 reasons.
1, By the time the beforeRender timestamp is taken, the image may
already be rendered. The assertion that renderTime >= beforeRender
therefore could fail.A previous CL fixes this. But the 2nd flakiness cause is found.
2, There was an assertion in the original test that the entryList of the
performance observer callback should be of size 1. This assertion is
carried over to the fix and is found to be causing flakiness as well.
It is because the performance observer has buffered option. At the
invocation of observer.observe(..}), the observer picks up the previous
entries and fire a deliver of the observer. Then, if this deliver is
actually executed after the 2nd element timing entry is added, the
entryList size would be 2. The assertion then fails.This CL fix it by removing the buffered option.
Bug: 1394227,1403318
Change-Id: I58a9da6832bccd4377696c7d7f50508ef1254011
Reviewed-on: https://chromium-review.googlesource.com/4139461
WPT-Export-Revision: 161defb68071682b59763d730f6160ed4d8ff45b
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
CI Results
Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 40 tests and 1 subtests
Status Summary
Firefox
OK
: 40
FAIL
: 40
Chrome
OK
: 40
PASS
: 40
Safari
OK
: 40
FAIL
: 40
Links
Details
New Tests That Don't Pass
- /element-timing/background-image-data-uri.html [wpt.fyi]
- Element with elementtiming attribute and inline background image is observable.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Element with elementtiming attribute and inline background image is observable.:
- /element-timing/background-image-multiple-elements.html [wpt.fyi]
- Background image affecting various elements is observed.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Background image affecting various elements is observed.:
- /element-timing/background-image-stretched.html [wpt.fyi]
- Element with background image shows correct image size.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Element with background image shows correct image size.:
- /element-timing/buffer-before-onload.html [wpt.fyi]
- Element Timing: image loads before onload available from buffered flag.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Element Timing: image loads before onload available from buffered flag.:
- /element-timing/buffered-flag.html [wpt.fyi]
- Element Timing entries are observable via buffered flag.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Element Timing entries are observable via buffered flag.:
- /element-timing/cross-origin-element.sub.html [wpt.fyi]
- Cross-origin image element is NOT observable.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Cross-origin image element is NOT observable.:
- /element-timing/cross-origin-iframe-element.sub.html [wpt.fyi]
- Element from cross origin iframe is NOT observable.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Element from cross origin iframe is NOT observable.:
- /element-timing/css-generated-text.html [wpt.fyi]
- Generated text content is observable.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Generated text content is observable.:
- /element-timing/disconnect-image.html [wpt.fyi]
- Disconnected elements have null as their |element| attribute.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Disconnected elements have null as their |element| attribute.:
- /element-timing/first-letter-background.html [wpt.fyi]
- Element with elementtiming attribute and background image in first-letter is observable.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Element with elementtiming attribute and background image in first-letter is observable.:
- /element-timing/fixed-id-identifier.html [wpt.fyi]
- PerformanceElementTiming id and identifier do not change when Element changes.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- PerformanceElementTiming id and identifier do not change when Element changes.:
- /element-timing/image-TAO.sub.html [wpt.fyi]
- Cross-origin elements with valid TAO have correct renderTime, with invalid TAO have renderTime set to 0.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Cross-origin elements with valid TAO have correct renderTime, with invalid TAO have renderTime set to 0.:
- /element-timing/image-carousel.html [wpt.fyi]
- Entries for elements within an image carousel are dispatched when the elements are redrawn.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Entries for elements within an image carousel are dispatched when the elements are redrawn.:
- /element-timing/image-clipped-svg.html [wpt.fyi]
- Able to observe svg image.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Able to observe svg image.:
- /element-timing/image-data-uri.html [wpt.fyi]
- Inline image is observable via Element Timing.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Inline image is observable via Element Timing.:
- /element-timing/image-not-fully-visible.html [wpt.fyi]
- The intersectionRect of an img element overflowing is computed correctly:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- The intersectionRect of an img element overflowing is computed correctly:
- /element-timing/image-src-change.html [wpt.fyi]
- Element Timing: changing src causes a new entry to be dispatched.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Element Timing: changing src causes a new entry to be dispatched.:
- /element-timing/image-with-css-scale.html [wpt.fyi]
- Image intersectionRect is affected by scaling, but not its intrinsic size.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Image intersectionRect is affected by scaling, but not its intrinsic size.:
- /element-timing/image-with-rotation.html [wpt.fyi]
- Image intersectionRect is affected by rotation, but not its intrinsic size.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Image intersectionRect is affected by rotation, but not its intrinsic size.:
- /element-timing/images-repeated-resource.html [wpt.fyi]
- Elements with elementtiming and same src are observable.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Elements with elementtiming and same src are observable.:
- /element-timing/multiple-background-images.html [wpt.fyi]
- Element with two background images receives both.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Element with two background images receives both.:
- /element-timing/multiple-redirects-TAO.html [wpt.fyi]
- Cross-origin images with passing/failing TAO should/shouldn't have its renderTime set.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Cross-origin images with passing/failing TAO should/shouldn't have its renderTime set.:
- /element-timing/observe-background-image.html [wpt.fyi]
- Element with elementtiming attribute and background image is observable.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Element with elementtiming attribute and background image is observable.:
- /element-timing/observe-child-element.html [wpt.fyi]
- Element in child iframe is not observed, even if same-origin.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Element in child iframe is not observed, even if same-origin.:
- /element-timing/observe-elementtiming.html [wpt.fyi]
- Element with elementtiming attribute is observable.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Element with elementtiming attribute is observable.:
- /element-timing/observe-empty-attribute.html [wpt.fyi]
- Able to observe image and text with empty elementtiming attribute.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Able to observe image and text with empty elementtiming attribute.:
- /element-timing/observe-multiple-images.html [wpt.fyi]
- PerformanceObserver can observe multiple image elements.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- PerformanceObserver can observe multiple image elements.:
- /element-timing/observe-shadow-image.html [wpt.fyi]
- Image in shadow tree with elementtiming attribute is not observable.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Image in shadow tree with elementtiming attribute is not observable.:
- /element-timing/observe-shadow-text.html [wpt.fyi]
- Text in shadow tree with elementtiming attribute is not observable.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Text in shadow tree with elementtiming attribute is not observable.:
- /element-timing/observe-svg-image.html [wpt.fyi]
- Able to observe svg image.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Able to observe svg image.:
- /element-timing/observe-text.html [wpt.fyi]
- Paragraph with elementtiming attribute is observed.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Paragraph with elementtiming attribute is observed.:
- /element-timing/observe-video-poster.html [wpt.fyi]
- Able to observe a video's poster image.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Able to observe a video's poster image.:
- /element-timing/progressively-loaded-image.html [wpt.fyi]
- Element Timing: image render timestamp occurs after it is fully loaded.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Element Timing: image render timestamp occurs after it is fully loaded.:
- /element-timing/rectangular-image.html [wpt.fyi]
- Element with rectangular image has correct rect and instrinsic size.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Element with rectangular image has correct rect and instrinsic size.:
- /element-timing/redirects-tao-star.html [wpt.fyi]
- Cross-origin image without TAO should not have its renderTime set, with full TAO it should.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Cross-origin image without TAO should not have its renderTime set, with full TAO it should.:
- /element-timing/retrievability.html [wpt.fyi]
- Element Timing entries are not accessible via performance.getEntries*:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Element Timing entries are not accessible via performance.getEntries*:
- /element-timing/same-origin-redirects.html [wpt.fyi]
- Same-origin image redirect without TAO should have its renderTime set.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Same-origin image redirect without TAO should have its renderTime set.:
- /element-timing/scroll-to-text.html [wpt.fyi]
- Paragraph with elementtiming attribute is observed even when not initially visible.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Paragraph with elementtiming attribute is observed even when not initially visible.:
- /element-timing/text-with-display-style.html [wpt.fyi]
- Text with display style is observable.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Text with display style is observable.:
- /element-timing/toJSON.html [wpt.fyi]
- Test toJSON() in PerformanceElementTiming.:
FAIL
(Chrome:PASS
, Safari:FAIL
)
- Test toJSON() in PerformanceElementTiming.:
Comment 4•2 years ago
|
||
bugherder |
Description
•