Open Bug 1808987 Opened 2 years ago Updated 1 years ago

Fenix packages about:license and various other toolkit about: pages which rely on info-pages.css, but doesn't package info-pages.css

Categories

(Fenix :: General, defect)

All
Android
defect

Tracking

(Not tracked)

People

(Reporter: Gijs, Unassigned)

References

Details

In bug 1724718 I am, after a ~16 month hiatus, once again trying to make it so we do not land references to chrome/resource files that do not exist (by making attempts to load such URLs crash, for files inside omni.ja and friends).

My trypush was quite orange and for junit tests says:

Mozilla crash reason: Missing chrome or resource URLs: chrome://global/skin/in-content/info-pages.css

info-pages.css is packaged in desktop-jar.inc.mn: https://searchfox.org/mozilla-central/rev/72d9bf2d4128990cd1f349d4e15003e515277982/toolkit/themes/shared/desktop-jar.inc.mn#51

As the name suggests, we do not package things in that file in mobile.

The referencing about:license page (opened from testAccessibilityFocusAboutMozilla which doesn't quite do what it says on the tin...) actually looks... fine, on mobile? Somewhat unstyled. But potentially more readable than if we did package info-pages.css .

The one caveat here is that we also don't package error-pages.css, and that gets used by the network error page and such. info-pages.css itself also has direct other toolkit consumers (e.g. about:support, about:serviceworkers, about:about, etc. etc.).

Summary: Fenix packages about:license which relies on info-pages.css, but doesn't package info-pages.css → Fenix packages about:license and various other toolkit about: pages which rely on info-pages.css, but doesn't package info-pages.css

It turns out chrome://global/skin/aboutLicense.css is also referenced and missing...

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(cpeterson)
Flags: needinfo?(cpeterson)
You need to log in before you can comment on or make changes to this bug.