Closed Bug 1809202 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 37812 - bluetooth: Fix DCHECK failure with calling forget() twice

Categories

(Core :: DOM: Device Interfaces, task, P4)

Product:
Core
Component:
DOM: Device Interfaces
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox111 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 37812 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37812
Details from upstream follow.

Jack Hsieh <chengweih@chromium.org> wrote:

bluetooth: Fix DCHECK failure with calling forget() twice

In the current default scenario of
features::kWebBluetoothNewPermissionsBackend disabled, there is a DCHECK
failure when forget() API is called twice. It is because forget() in the
old permission backend flow blindly passes the device_address for
RemoveDevice() without validating the device_address. The change fixes
it by checking if the device_address is valid as RemoveDevice() expects
a valid one.

Bug: 1403822
Change-Id: Ib1cdf7db988b122b1b8fec820fc67a19c25b4415
Reviewed-on: https://chromium-review.googlesource.com/4146018
WPT-Export-Revision: 66bbf966dcb0ded6a6e179bb60e69715c3d26678

Component: web-platform-tests → DOM: Device Interfaces
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

ERROR: 1

Chrome

OK : 1
FAIL : 1

Safari

ERROR: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/342b59141983 [wpt PR 37812] - bluetooth: Fix DCHECK failure with calling forget() twice, a=testonly

https://hg.mozilla.org/mozilla-central/rev/342b59141983

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox111: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.